-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added options to make PR compare against base branch and then output result #17
Conversation
Thank you for adding this. Let me review this PR this weekend. |
Hey, any update on this? |
I'm sorry for the delay. I'm now focusing on another private project and could not review this last weekend. Let me check now. |
I removed the |
Thanks for the responses. I also left a comment in outdated conversation. #17 (comment) |
@rhysd I have addressed your review. The only thing left to decide is #17 (comment). I really want some customization here because it looks really ugly otherwise. |
Codecov Report
@@ Coverage Diff @@
## master #17 +/- ##
==========================================
- Coverage 92.27% 88.64% -3.64%
==========================================
Files 5 5
Lines 518 546 +28
Branches 95 101 +6
==========================================
+ Hits 478 484 +6
- Misses 18 37 +19
- Partials 22 25 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thank you for the updates.
@pksunkara I merged this. Thank you for your contribution. I'll make a new release tomorrow. |
I'm sorry for the delay. I released new version v1.8.0 including this patch. |
clap-rs/clap#1724 is the PR you can see.
As you can see there, both the options are working.