Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track controller stream subscription and cancel on dispose #43

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## [7.0.2]

- Tracks `StreamSubscription<ControllerEvent>` given `widget.controller`, and calls `cancel` on dispose.

## [7.0.1]

- Prevents `CardSwiperController` to be disposed by `CardSwiper`.
Expand Down
1 change: 1 addition & 0 deletions lib/src/widget/card_swiper.dart
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import 'dart:async';
import 'dart:collection';
import 'dart:math' as math;

Expand Down
5 changes: 4 additions & 1 deletion lib/src/widget/card_swiper_state.dart
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,15 @@ class _CardSwiperState<T extends Widget> extends State<CardSwiper>

bool get _canSwipe => _currentIndex != null && !widget.isDisabled;

StreamSubscription<ControllerEvent>? controllerSubscription;

@override
void initState() {
super.initState();

_undoableIndex.state = widget.initialIndex;

widget.controller?.events.listen(_controllerListener);
controllerSubscription = widget.controller?.events.listen(_controllerListener);

_animationController = AnimationController(
duration: widget.duration,
Expand Down Expand Up @@ -65,6 +67,7 @@ class _CardSwiperState<T extends Widget> extends State<CardSwiper>
@override
void dispose() {
_animationController.dispose();
controllerSubscription?.cancel();
super.dispose();
}

Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: flutter_card_swiper
description: This is a Tinder-like card swiper package. It allows you to swipe left, right, up, and down and define your own business logic for each direction.
homepage: https://github.com/ricardodalarme/flutter_card_swiper
issue_tracker: https://github.com/ricardodalarme/flutter_card_swiper/issues
version: 7.0.1
version: 7.0.2

environment:
sdk: ">=3.0.0 <4.0.0"
Expand Down
Loading