Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test relies on specific output from sample_islands() for given seed #500

Closed
szhorvat opened this issue Oct 22, 2023 · 4 comments · Fixed by #512
Closed

Test relies on specific output from sample_islands() for given seed #500

szhorvat opened this issue Oct 22, 2023 · 4 comments · Fixed by #512

Comments

@szhorvat
Copy link

The "counting the number of strongly connected components is possible" test currently relies on igraph's sample_islands() function returning a specific output for a specific seed.

https://github.com/rich-iannone/DiagrammeR/blob/main/tests/testthat/test-count_entities.R#L129

We do not guarantee that the output of such stochastic functions won't change across versions (for the same seed). Can you please refactor the test not to rely on this? In an upcoming version of igraph, sample_islands() will change, causing this test to fail.

@szhorvat
Copy link
Author

On a related note, the title of this test mentions "strongly connected components", but the test is executed for an undirected graph, which doesn't look right.

@krlmlr
Copy link

krlmlr commented Dec 7, 2023

@rich-iannone: We're releasing igraph 2.0.0 just before CRAN closes for Christmas. Tracking issue: igraph/rigraph#989.

@krlmlr
Copy link

krlmlr commented Dec 13, 2023

New anticipated release data: January 12.

@krlmlr
Copy link

krlmlr commented Jan 21, 2024

We're planning to send igraph to CRAN on January 23, we're still seeing failures with this package: https://github.com/igraph/rigraph/blob/main/revdep/problems.md .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants