Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort on save is broken? #78

Open
tylerlaprade opened this issue Mar 27, 2023 · 3 comments
Open

Sort on save is broken? #78

tylerlaprade opened this issue Mar 27, 2023 · 3 comments

Comments

@tylerlaprade
Copy link

tylerlaprade commented Mar 27, 2023

I tried both, "all formatters" and specifically enabling just this formatter. Neither autoformats on save for me.

@dantefromhell
Copy link

dantefromhell commented Jun 7, 2023

Yeah I'm seeing the same issue with version richie5um2.vscode-sort-json@1.20.0 on VSCode 1.78.2.

My test files are a workspace and user settings.json file, the auto-format on save configuration is c&p from the README

    "editor.codeActionsOnSave": {
        "source.fixAll.sortJSON": true
    }

Manually sorting the files works as expected, the 'sort on save' though is not triggered.

I'm happy to troubleshoot, any hints where to start?

@dlastrazeneca
Copy link

I'm seeing the same issue. Manual sorting via the command palette is fine, but workspace settings.json is not respected.

@mcm-ham
Copy link

mcm-ham commented Sep 7, 2023

You can use VSCode built-in JSON sort on save json.sortOnSave.enable (will be changed to "editor.codeActionsOnSave": { "source.sort.json": true } on Sep 23 release).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants