Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to highlight variable names starting with $ in Perl as well #107

Closed
ericcirone opened this issue Nov 30, 2015 · 4 comments
Closed

Need to highlight variable names starting with $ in Perl as well #107

ericcirone opened this issue Nov 30, 2015 · 4 comments

Comments

@ericcirone
Copy link

I see you added special case to catch names with "$" in PHP. This is needed for Perl too. If you hightlight "$var1" you will not get any matches. If you turn off whole word only, then it works.

@PhiLhoSoft
Copy link

Actually, the root of the problem is probably from the borrowed code from find-and-replace module:

atom/find-and-replace#576

So the behavior with regard to non word chars should be fixed, instead of adding exceptions for a limited number of languages... (should be applied to JavaScript, Java, Stylus and other related CSS languages, perhaps Ruby?, and so on).
And the problem goes beyond: if I want to add . and # to the word chars of CSS, when I double-click #FFF or .foo they are wholly selected, but other occurrences are not highlighted.
While foo-bar is, perhaps because of another special case in code...

@mj41
Copy link

mj41 commented Feb 7, 2017

Probably related to: #73, #141, #132, #117, #88

@mj41
Copy link

mj41 commented Feb 7, 2017

FYI: You can disable "Only Highlight Whole Words" to workaround for language-perl "Non Word Characters" (/\()"':,.;<>~!#^*|+=[]{}``?-… ). Of course both $foo and $foobar will be highlighted if you select $foo.

@richrace
Copy link
Member

See #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants