Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated selector in highlight-selected/styles/highlight-selected.less #131

Closed
Nikki1993 opened this issue Oct 20, 2016 · 10 comments
Closed

Comments

@Nikki1993
Copy link

In highlight-selected/styles/highlight-selected.less:

Starting from Atom v1.13.0, the contents of atom-text-editor elements are no longer encapsulated within a shadow DOM boundary. This means you should stop using :host and ::shadow pseudo-selectors, and prepend all your syntax selectors with syntax--. To prevent breakage with existing style sheets, Atom will automatically upgrade the following selectors:

  • :host atom-text-editor .highlight.highlight-selected .region, atom-text-editor atom-text-editor .highlight.highlight-selected .region, atom-text-editor::shadow atom-text-editor .highlight.highlight-selected .region => :host atom-text-editor .highlight.highlight-selected .region, atom-text-editor atom-text-editor .highlight.highlight-selected .region, atom-text-editor atom-text-editor .highlight.highlight-selected .region
  • :host .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region, atom-text-editor::shadow .highlights .highlight-selected .region => :host .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region
  • :host .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region, atom-text-editor::shadow .highlights .highlight-selected .region => :host .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region, atom-text-editor .highlights .highlight-selected .region
  • :host .highlights .highlight-selected.background .region, atom-text-editor .highlights .highlight-selected.background .region, atom-text-editor::shadow .highlights .highlight-selected.background .region => :host .highlights .highlight-selected.background .region, atom-text-editor .highlights .highlight-selected.background .region, atom-text-editor .highlights .highlight-selected.syntax--background .region
  • :host .highlights .highlight-selected.light-theme .region, atom-text-editor .highlights .highlight-selected.light-theme .region, atom-text-editor::shadow .highlights .highlight-selected.light-theme .region => :host .highlights .highlight-selected.light-theme .region, atom-text-editor .highlights .highlight-selected.light-theme .region, atom-text-editor .highlights .highlight-selected.light-theme .region
  • :host .highlights .highlight-selected.light-theme.background .region, atom-text-editor .highlights .highlight-selected.light-theme.background .region, atom-text-editor::shadow .highlights .highlight-selected.light-theme.background .region => :host .highlights .highlight-selected.light-theme.background .region, atom-text-editor .highlights .highlight-selected.light-theme.background .region, atom-text-editor .highlights .highlight-selected.light-theme.syntax--background .region

Automatic translation of selectors will be removed in a few release cycles to minimize startup time. Please, make sure to upgrade the above selectors as soon as possible.

@aphive
Copy link

aphive commented Nov 17, 2016

Any updates on this issue?

@davherrmann
Copy link

I think #136 will fix this – maybe wait for Atom 1.13 stable? See When should I migrate my package?

@SirWaddles
Copy link

1.13 is now the main stable release

@aadityamaheshwari
Copy link

I am on stable 1.13.0 (latest MacOS) and can confirm issue still exists.

@cliffordfajardo
Copy link

Also getting deprecation alerts from Atom & I'm on 1.13.0

@Kerwood
Copy link

Kerwood commented Jan 11, 2017

Still Waiting

@richrace
Copy link
Member

Waiting for https://travis-ci.org/richrace/highlight-selected/jobs/191092635 to pass...

@aphive
Copy link

aphive commented Jan 18, 2017

Looks like just about all the 3rd party extensions are broken. I have seen several already that are getting the same error...

@richrace
Copy link
Member

Could you please share any 3rd party extensions. I'm only aware of minimap-highlight-selected

@Kerwood
Copy link

Kerwood commented Jan 18, 2017

Mine updated just fine yesterday

Wigginns added a commit to Wigginns/highlight-selected that referenced this issue Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants