Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HighlightedAreaView.onDidAddMarker is deprecated. #147

Closed
TheSeg opened this issue Mar 23, 2017 · 18 comments
Closed

HighlightedAreaView.onDidAddMarker is deprecated. #147

TheSeg opened this issue Mar 23, 2017 · 18 comments

Comments

@TheSeg
Copy link

TheSeg commented Mar 23, 2017

Deprecation warning on version 0.13.0 (Atom 1.15.0). This issue is from the auto generated button from the deprecation cop.

Please do not use. This method will be removed.

HighlightedAreaView.onDidAddMarker (/Users/jseggerson/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:62:12)
onDidAddMarker (/Users/jseggerson/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59)
MinimapHighlightSelected.init (/Users/jseggerson/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:58:30)
init (/Users/jseggerson/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59)
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 (/Users/jseggerson/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21)
Provider.provide (/Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52)
@richrace
Copy link
Member

This pull requested needs to be merged: atom-minimap/minimap-highlight-selected#39

@rafro
Copy link

rafro commented Mar 24, 2017

How would one go about merging this pull request?

@arsari
Copy link

arsari commented Mar 24, 2017

I get 2 deprecation warning on version 0.13.1 on Atom 1.15.0...

Please do not use. This method will be removed.
REPORT ISSUE
HighlightedAreaView.onDidAddMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:62:12
onDidAddMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59
MinimapHighlightSelected.init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:58:30
init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21
Provider.provide - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52

Please do not use. This method will be removed.
REPORT ISSUE
HighlightedAreaView.onDidAddSelectedMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:69:12
onDidAddSelectedMarker - /Users/arsari/.atom/packages/highlight-selected/lib/highlighted-area-view.coffee:3:59
MinimapHighlightSelected.init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:63:30
init - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:3:59
MinimapHighlightSelected.consumeHighlightSelectedServiceV1 - /Users/arsari/.atom/packages/minimap-highlight-selected/lib/minimap-highlight-selected.coffee:28:21
Provider.provide - /Applications/Atom.app/Contents/Resources/app.asar/node_modules/service-hub/lib/provider.js:29:52

@JeffCleverley
Copy link

Same two deprecations as above

1 similar comment
@Cherkah
Copy link

Cherkah commented Mar 25, 2017

Same two deprecations as above

@greenais
Copy link

Same here

@carrodher
Copy link

Same here for 1.16.0-beta0

@franciscoestevao
Copy link

franciscoestevao commented Mar 26, 2017

same for 0.13.1

@Astlvk
Copy link

Astlvk commented Mar 27, 2017

Same here for 1.16.0-beta0

@Gscdae
Copy link

Gscdae commented Mar 27, 2017

Same here for 0.13.1

1 similar comment
@juvevood
Copy link

Same here for 0.13.1

@rkabrahpudi
Copy link

Same here 0.13.1

@akaybagorov
Copy link

+1

@dragonfoxsl
Copy link

just updated and same here for 0.13.1 in atom 1.15.0

@dqfan2012
Copy link

dqfan2012 commented Mar 27, 2017

Same.
Atom: 1.15.0
highlight-selected: 0.13.1

@bbroens
Copy link

bbroens commented Mar 28, 2017

Likewise

@okonomiyaki3000
Copy link

Guys stop.. He got the message. You're not contributing anything.

@Pulsar-Edit-Highlights Pulsar-Edit-Highlights locked and limited conversation to collaborators Mar 28, 2017
@richrace
Copy link
Member

I've locked this issue as this is caused by another package using an API that causes bugs.

Once this pull request gets merged, the deprecated warnings will go away: atom-minimap/minimap-highlight-selected#39

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests