Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not closing the bottom/top of the highlight on line 144/145 #84

Closed
dionisiusma opened this issue Jun 17, 2015 · 4 comments
Closed

Not closing the bottom/top of the highlight on line 144/145 #84

dionisiusma opened this issue Jun 17, 2015 · 4 comments
Labels

Comments

@dionisiusma
Copy link

I first noticed the issue while coding in PHP, but I just tested it on plain text and the errors persists.

STR: just put a lot of text in a file and selected/highlight some word on the line 144 and look for problems on the bottom border of the highlight. If everything is okay, check the top border of a selected word on the line 145. See image below:

atombug

ER: Bottom border closing the rectangle.

@richrace
Copy link
Member

Yea, I've seen this recently. Just had a quick look. It's basically a CSS issue. I need to update the following:

.highlight-selected .region {
      border-radius: 2px;
      box-sizing: content-box;
      padding: 0 1px 0 0;
      margin: -1px 0 0 -1px;
      background-color: transparent;
      border-width: 1px;
      border-style: solid;
    }

to:

.highlight-selected .region {
      // Maybe make this 3px (be the same as find-and-replace package
      border-radius: 2px; 
      box-sizing: border-box;
      background-color: transparent;
      border-width: 1px;
      border-style: solid;
    }

@richrace richrace added the bug label Jun 17, 2015
@dionisiusma
Copy link
Author

Ok. Do you know why it happens at line 144 or 145? :S

@richrace
Copy link
Member

Nope. What I've been experiencing locally is more random. Sometimes the bottom of the box or a side (left or right) is sometimes missing. I think it might have been something to do with the new tiling rendering of the lines.

@dionisiusma
Copy link
Author

Hmmm, strange. Maybe it was just a coincidence for me then. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants