Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on 'atom-space-pen-views' #78

Merged
merged 1 commit into from
Jun 14, 2015

Conversation

jccr
Copy link
Contributor

@jccr jccr commented Jun 13, 2015

I noticed this package took the longest to load on my setup. It takes around 40-60ms to load according to Timecop.
With the removal of space-pen-views as a dependency this reduced the load time to ~5ms.

Is there a reason as to why this needs to be a space pen view that attaches itself as a panel to the workspace?

PS: Thanks for creating this essential package!

Doing this improves package loading time.
@jccr
Copy link
Contributor Author

jccr commented Jun 13, 2015

Whoops, looks like I did not see #60

@jccr
Copy link
Contributor Author

jccr commented Jun 13, 2015

Ok, now that I scanned through the history of #60 and all the references..

@richrace
Looks like this package wants to be merged in with atom/find-and-replace and you last said in Feb that you didn't have time to work on this. It's been a few months now.. Do you of anyone who is currently looking in to this? If not I'd be willing to help.

@richrace
Copy link
Member

I'll merge yours in as I had some issues with my branch. Thanks for this. As I renamed the files it broke the minimap plugin. But this doesn't.

If you want to look at merging it into the find and replace package that would cool. However, we should look at implementing the API for the minimap package first, imo. As far as I'm aware, no one else is looking into it.

richrace added a commit that referenced this pull request Jun 14, 2015
Remove dependency on 'atom-space-pen-views'
@richrace richrace merged commit 1b30631 into Pulsar-Edit-Highlights:master Jun 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants