Updated version of #337: Cross compile to Scala Native #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shadaj Thanks! Could you maybe rebase this PR, to at least get rid of the merge-commits? The PR currently has 11 commits, but changes very little code. |
|
@rickynils Just rebased and squashed the commits! Looks like a Scala.js build failed due to a timeout, but that should be unrelated to the Scala Native changes. |
|
@rickynils Just re-ran the Travis build, and everything is passing now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of the original PR #337 by @Duhemm to update to a more recent master. It also includes changes that should make the Travis-CI build pass.