Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socktap as a shared library #144

Open
khevessy opened this issue Feb 7, 2022 · 3 comments
Open

Socktap as a shared library #144

khevessy opened this issue Feb 7, 2022 · 3 comments

Comments

@khevessy
Copy link
Contributor

khevessy commented Feb 7, 2022

Hello,

I have a question: is there some simple way to compile features introduced in Socktap as shared library? I am asking as I am using the switch BUILD_SHARED_LIBS in main CMakeLists.txt to build whole Vanetza as shared libraries, so I wondered if there is anything like this for Socktap. Maybe I am just silly as it is just meant as a standalone binary only.

For context: Socktap example is now working for me on the Craton 2 platform (I wrote the new link layer for the example). However, I want to develop my own CA service on facilities layer and I need to be using all of your code as a shared library.

Is this possible or do I have to just rewrite the whole part of interfacing the application with Vanetza library code for myself? I doubt I can do it from scratch.

Thank you,
Karel

@khevessy khevessy changed the title Socktap as shared library Socktap as a shared library Feb 7, 2022
@riebl
Copy link
Owner

riebl commented Feb 7, 2022

Code located in the tools subdirectory is not available as a library at the moment. If there is code generic enough to be re-used I suggest moving it into Vanetza's library section, i.e. to the vanetza subdirectory. Which classes and functions do you want to have in a library exactly?

@khevessy
Copy link
Contributor Author

khevessy commented Feb 8, 2022

I thought mainly about classes RouterContext, TimeTrigger and Application, maybe even DccPassthrough (I won't use this one once I will be using DCC mechanisms from Vanetza) as I reused those exactly as they were, but maybe you are right it is not generic enough or just does not belong to the library itself. But from my side it is something that everyone using the library will use.

On another note, do you think I should try to do a pull request with changes for link layer variant with Autotalks API that I did directly in the Vanetza example?

@riebl
Copy link
Owner

riebl commented Feb 15, 2022

I will have a look at which components may be moved to the library section of Vanetza.
Pull requests of any form are always welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants