New: Limited support for barriers #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameyer-rigetti
force-pushed
the
7-barrier-support
branch
2 times, most recently
from
020e2d4 to
4a0d542
Compare
ameyer-rigetti
commented
Jul 20, 2021
ameyer-rigetti
commented
Jul 20, 2021
| @@ -28,17 +28,6 @@ | |||
| from ._qcs_job import RigettiQCSJob | |||
|
|
|||
|
|
|||
| def _remove_barriers(circuit: QuantumCircuit) -> None: | |||
There was a problem hiding this comment.
Barrier handling has been moved into the RigettiQCSJob class, as there's no straightforward way to replace the instruction with a pragma here
ameyer-rigetti
force-pushed
the
7-barrier-support
branch
from
4a0d542 to
ae21aa1
Compare
ameyer-rigetti
commented
Jul 20, 2021
ameyer-rigetti
commented
Jul 20, 2021
| def test_init__circuit_with_barrier__qubit_subset(backend: RigettiQCSBackend, mocker: MockerFixture): | ||
| circuit = QuilCircuit(QuantumRegister(2, "q"), ClassicalRegister(2, "ro")) | ||
| circuit.h(0) | ||
| circuit.barrier(0) |
There was a problem hiding this comment.
Note that for now, we're taking a naive approach and only "translating" barriers applied to all qubits -- even if it might still be possible to translate it with some deeper/more complex analysis (like in this example, since the only qubit involved is q0).
notmgsk
reviewed
Jul 20, 2021
ameyer-rigetti
force-pushed
the
7-barrier-support
branch
2 times, most recently
from
10a163a to
7b00a98
Compare
notmgsk
reviewed
Jul 20, 2021
| ): | ||
| make_job(backend, circuit, qc) | ||
|
|
||
| program: Program = quil_to_native_quil_spy.call_args[0][0] |
notmgsk
approved these changes
Jul 20, 2021
ameyer-rigetti
force-pushed
the
7-barrier-support
branch
from
7b00a98 to
cb45db1
Compare
|
🎉 This PR is included in version 0.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For QASM
barriers affecting all qubits, replace with an empty QuilPRESERVE_BLOCK. Otherwise, omit.Closes #7