Add mnio_connections section #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanbro
reviewed
Dec 18, 2020
rpcq/core_messages.py
Outdated
| @@ -694,7 +711,7 @@ class QFDChannel(Message): | |||
| flux_current: Optional[float] = None | |||
| """Flux current [Amps].""" | |||
|
|
|||
| relay_closed: Optional[bool] = None | |||
| relay_closed: Optional[bool] = False | |||
There was a problem hiding this comment.
Unfortunately auto-generation is broken for this. Can you manually set it back to None?
There was a problem hiding this comment.
My apologies. When the auto-gen ran I just assumed it correct. Changing it now.
notmgsk
approved these changes
Dec 21, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an
mnio_connectionssection to instruments in rack YAMLs.