Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat all ID numbers as strings #24

Closed
rileyhales opened this issue Dec 1, 2021 · 0 comments · Fixed by #32
Closed

Treat all ID numbers as strings #24

rileyhales opened this issue Dec 1, 2021 · 0 comments · Fixed by #32
Labels
bug Something isn't working enhancement New feature or request

Comments

@rileyhales
Copy link
Owner

Code sometimes coerces ID numbers to be numeric- int or float. Should treat all id numbers as strings. Sometimes causes problems e.g. when ID numbers have leading zeros like with some USGS gauges or if the gauge ID is alphanumeric.
@rileyhales rileyhales added bug Something isn't working enhancement New feature or request labels Dec 1, 2021
@rileyhales rileyhales mentioned this issue Aug 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Many improvements rileyhales/saber-hbc
1 participant
@rileyhales