Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delete selected candidate #557

Merged
merged 2 commits into from
Jun 23, 2022
Merged

feat: delete selected candidate #557

merged 2 commits into from
Jun 23, 2022

Conversation

InfinityLoop1308
Copy link
Contributor

@InfinityLoop1308 InfinityLoop1308 commented Jun 23, 2022

Pull request

Issue tracker

This is a continuation of #556.

Feature

This feature supports deleting candidate at arbitrary index, which is useful for quick deleting.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

InfinityLoop1308 and others added 2 commits June 23, 2022 18:25
eliminate unuseful function argument that hinders readability;
adjust indentation to match Google C++ style.
@lotem lotem merged commit 43023e1 into rime:master Jun 23, 2022
@lotem
Copy link
Member

lotem commented Jun 23, 2022

Thanks, merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants