Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade yaml-cpp to 0.8.0 #705

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Upgrade yaml-cpp to 0.8.0 #705

merged 3 commits into from
Sep 4, 2023

Conversation

Bambooin
Copy link
Contributor

@Bambooin Bambooin commented Sep 4, 2023

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

@Bambooin
Copy link
Contributor Author

Bambooin commented Sep 4, 2023

Lack of skill to fix Windows builds, need help, relative to #704.

We can combine two pull requests into one with #704.

@Bambooin
fix: fix cmake conflict in yaml-cpp 0.8.0
a5baaad 
CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.
@Bambooin
chore: upgrade yaml-cpp to 0.8.0
1d29b89
@eagleoflqj
Copy link
Member

Lack of skill to fix Windows builds, need help, relative to #704.

Sure, I can take a look (no guarantee to fix of course).

We can combine two pull requests into one with #704.

Nope, I decided to drop yaml-cpp in that PR 😂

@eagleoflqj
Copy link
Member

Using git bisect it’s easy to identify jbeder/yaml-cpp@2b65c65 breaks. From dll.h we know YAML_CPP_STATIC_DEFINE has to be defined when building librime, otherwise librime thinks yaml-cpp is built as dll so its api is decorated with __declspec(dllimport).

@eagleoflqj eagleoflqj merged commit be3af89 into rime:master Sep 4, 2023
7 checks passed
@Bambooin
Copy link
Contributor Author

Bambooin commented Sep 5, 2023

Thanks for your fix and find the root cause. 👍

@eagleoflqj eagleoflqj mentioned this pull request Sep 22, 2023
Merged
2 tasks
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
@Bambooin @eagleoflqj @groverlynn
Upgrade yaml-cpp to 0.8.0 (rime#705)
a4eae87 
* fix cmake conflict in yaml-cpp 0.8.0

CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.

* chore: upgrade yaml-cpp to 0.8.0

* fix yaml-cpp 0.8.0 build

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
@Bambooin @eagleoflqj @graphemecluster
Upgrade yaml-cpp to 0.8.0 (rime#705)
e230c73 
* fix cmake conflict in yaml-cpp 0.8.0

CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.

* chore: upgrade yaml-cpp to 0.8.0

* fix yaml-cpp 0.8.0 build

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@Bambooin @eagleoflqj @graphemecluster
Upgrade yaml-cpp to 0.8.0 (rime#705)
7b1a2e5 
* fix cmake conflict in yaml-cpp 0.8.0

CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.

* chore: upgrade yaml-cpp to 0.8.0

* fix yaml-cpp 0.8.0 build

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
@Bambooin @eagleoflqj @graphemecluster
Upgrade yaml-cpp to 0.8.0 (rime#705)
c762bf8 
* fix cmake conflict in yaml-cpp 0.8.0

CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.

* chore: upgrade yaml-cpp to 0.8.0

* fix yaml-cpp 0.8.0 build

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
@Bambooin @eagleoflqj @graphemecluster
Upgrade yaml-cpp to 0.8.0 (rime#705)
374c2c2 
* fix cmake conflict in yaml-cpp 0.8.0

CMake Error at librime/CMakeLists.txt:187 (add_custom_target):
  add_custom_target cannot create target "uninstall" because another target
  with the same name already exists.  The existing target is a custom target
  created in source directory
  "github/trime/app/src/main/jni/librime/deps/yaml-cpp".  See
  documentation for policy CMP0002 for more details.

* chore: upgrade yaml-cpp to 0.8.0

* fix yaml-cpp 0.8.0 build

---------

Co-authored-by: Qijia Liu <liumeo@pku.edu.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bambooin @eagleoflqj