Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused cmake file FindKyotoCabinet.cmake #714

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Delete unused cmake file FindKyotoCabinet.cmake #714

merged 1 commit into from
Sep 17, 2023

Conversation

AlfredLouis00
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This effectively drops https://github.com/rime/librime-legacy , which I think is a correct move.
If someone needs that, something could be done in the plugin repo to revive.

@eagleoflqj eagleoflqj merged commit 72a6406 into rime:master Sep 17, 2023
8 checks passed
@AlfredLouis00 AlfredLouis00 deleted the delete-cmake branch September 21, 2023 06:31
groverlynn pushed a commit to groverlynn/librime that referenced this pull request Sep 27, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 2, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Nov 8, 2023
graphemecluster pushed a commit to TypeDuck-HK/librime that referenced this pull request Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants