Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace some types of Boost with std's #738

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Replace some types of Boost with std's #738

merged 3 commits into from
Oct 24, 2023

Conversation

WhiredPlanck
Copy link
Contributor

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes # N/A

Feature

Describe feature of pull request

Replace some types of Boost with std's.

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

lotem
lotem approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@lotem lotem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

eagleoflqj
eagleoflqj requested changes Oct 16, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix CI

@WhiredPlanck WhiredPlanck mentioned this pull request Oct 22, 2023
Closed
@WhiredPlanck
Copy link
Contributor Author

Please fix CI

@eagleoflqj librime-lua fixed it by its latest commit.

eagleoflqj
eagleoflqj approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@eagleoflqj eagleoflqj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work

@eagleoflqj eagleoflqj merged commit 526f6e8 into rime:master Oct 24, 2023
15 of 16 checks passed
@WhiredPlanck WhiredPlanck deleted the types branch October 24, 2023 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eagleoflqj eagleoflqj eagleoflqj approved these changes

@lotem lotem lotem approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WhiredPlanck @lotem @eagleoflqj