Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deployment_tasks): do not remove log files in use #913

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

ksqsf
Copy link
Member

@ksqsf ksqsf commented Jul 13, 2024

Do not remove the symlinked log files, because they are still in use.

Pull request

Issue tracker

Fixes will automatically close the related issue

Fixes #902
Fixes rime/squirrel#948

Feature

Describe feature of pull request

Unit test

  • Done

Manual test

  • Done

Code Review

  1. Unit and manual test pass
  2. GitHub Action CI pass
  3. At least one contributor reviews and votes
  4. Can be merged clean without conflicts
  5. PR will be merged by rebase upstream base

Additional Info

To verify this PR:

  1. Restart Squirrel and see log files
  2. Advance the system date by 1 day
  3. Redeploy
    • BEFORE: log files gone!
    • AFTER: the current log file should be kept.

Copy link
Contributor

@fxliang fxliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it would keep the logs of apps works thought days.

@ksqsf ksqsf merged commit f6dd300 into rime:master Jul 17, 2024
10 checks passed
@ksqsf ksqsf deleted the fix-CleanOldLogFiles branch July 17, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

鼠须管的日志问题 鼠须管的日志问题
2 participants