Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example with using window scroll #160

Closed
AGLearning opened this issue Dec 15, 2017 · 7 comments
Closed

Example with using window scroll #160

AGLearning opened this issue Dec 15, 2017 · 7 comments

Comments

@AGLearning
Copy link

AGLearning commented Dec 15, 2017

Could you add some example with window scroll (in demo). I can't get it working:/

@RockNHawk
Copy link

+1
I'm also

@robvaneck
Copy link

Im also wondering if you have an example. Im still seeing two scrollbars
https://ibb.co/n4ETKG

@RockNHawk
Copy link

@borriej yeah yeah that's the problem.

@robvaneck
Copy link

any updates on this @rintoj :) ?

@speige
Copy link
Collaborator

speige commented Jul 19, 2018

Related to #138

This does actually work, but the previous version had a few glitches that made it harder to setup.

#1) The documentation was incorrect, scroll.window wasn't actually defined, so you had to make a public window property on your own component for binding to parentScroll. The scroll.window property does exist now.
#2) You had to add css to the parentElement (or body if using window) for overflow. This is now done automatically.
#3) virtual-scroll always had overflow defined on its css, but it should have only been set if parentScroll was undefined, so you had to override this to make parentScroll work. This has been corrected.

Note: You have to put a fixed size on the parent element (or body if using window), instead of on the virtual-scroll itself.

Please update to the latest version from npm & see if it's working for you. If not, please submit a code sample or a stackblitz to help troubleshoot.

@speige
Copy link
Collaborator

speige commented Jul 23, 2018

I've added an example of this to the demo app that's part of this github repo.

@speige
Copy link
Collaborator

speige commented Aug 2, 2018

The demo is available on github. I'm waiting on rintoj to update it here:
http://rintoj.github.io/angular2-virtual-scroll/

Either way, I believe this issue is fixed.

Closing this since I haven't received a response from the original poster. Please re-open if you continue to experience this issue.

@speige speige closed this as completed Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants