ensure that onScrollListener is actually defined before removing #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem when using VirtualScrollComponent in my application and writing tests. A single test containing the VirtualScrollComponent failed (see below) and as a results all following tests also failed. It was very hard to find out the actual problem but I think I could figure out the original cause.
Repro:
it('should throw if no ... is given', () => { expect(() => fixture.detectChanges()).toThrowError(); });
-> I could fix this by ensuring that
onScrollListener
is not undefined before removing the listener.