Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date-based paging support to EndpointPaging #75

Open
rinukkusu opened this issue Oct 12, 2020 · 4 comments
Open

Add date-based paging support to EndpointPaging #75

rinukkusu opened this issue Oct 12, 2020 · 4 comments

Comments

@rinukkusu
Copy link
Owner

In PR #66 date-based paging has been added to the me.recentlyPlayed() endpoint.
As a developer I'd like to use this kind of paging in other places as well, so it would be great to have it implemented in EndpointPaging itself directly. We'll probably need seperate paging classes for offset- and date-based paging.

@hayribakici
Copy link
Collaborator

It would be good to know, which API endpoints are providing the before or after query parameters. So far, I have seen it only in the recently-played endpoint. Do you know any other?

@rinukkusu
Copy link
Owner Author

True, I have not yet investigated which endpoints are actually using that. If we find out, that recently-played is the only one - great, then we can close the PR 😄

@thosakwe
Copy link

thosakwe commented Jul 20, 2021

Were there any other endpoints that use date-based paging?

@hayribakici
Copy link
Collaborator

hayribakici commented Jul 20, 2021

I looked it into today and so far only the recenty-played endpoint has a timestamp (before and after) query parameters.
If you would like, you can also check it out here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants