You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #145 I found out that our capture-avoiding substitution was bugged. The condition to alpha-rename should be FV(expression) contains x and not FV(b) contains x:
However changing the alpha-renaming condition breaks tests like harrisCornerDetectionHalideCheck and cameraPipelineCheck, indicating another bug in our codebase. My intuition tells me that it could be related to #81, since alpha-renaming more often reduces the risk of having non-unique names. @michel-steuwer@umazalakain
The text was updated successfully, but these errors were encountered:
In #145 I found out that our capture-avoiding substitution was bugged. The condition to alpha-rename should be
FV(expression) contains x
and notFV(b) contains x
:shine/src/main/scala/rise/core/substitute.scala
Lines 33 to 43 in 9b04bf2
However changing the alpha-renaming condition breaks tests like
harrisCornerDetectionHalideCheck
andcameraPipelineCheck
, indicating another bug in our codebase. My intuition tells me that it could be related to #81, since alpha-renaming more often reduces the risk of having non-unique names.@michel-steuwer @umazalakain
The text was updated successfully, but these errors were encountered: