Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace ctor by linkme #14814

Merged
merged 4 commits into from
Feb 1, 2024
Merged

refactor: replace ctor by linkme #14814

merged 4 commits into from
Feb 1, 2024

Conversation

wangrunji0408
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR replaces ctor by linkme, which simplifies the code and initialization process.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

@wangrunji0408 wangrunji0408 requested a review from a team as a code owner January 26, 2024 06:51
BugenZhao
BugenZhao approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. While it may not be as flexible as ctor, it aligns perfectly with our use case. 🤩

@BugenZhao
Copy link
Member

Wow, compilation failed. 😕

@wangrunji0408
Copy link
Contributor Author

wangrunji0408 commented Jan 26, 2024 •
edited
Loading

Looks like we encountered this problem dtolnay/linkme#49.
linkme is not compatible with our linker configuration on linux...

@wangrunji0408
use linkme to replace ctor
ba5c242 
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408
replace ctor in frontend
3c41911 
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408 wangrunji0408 reopened this Feb 1, 2024
@wangrunji0408
enable "used_linker" feature
acfe11d 
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408
revert system catalog id
4b6f2b3 
Signed-off-by: Runji Wang <wangrunji0408@163.com>
@wangrunji0408
Copy link
Contributor Author

Looks like we encountered this problem dtolnay/linkme#49. linkme is not compatible with our linker configuration on linux...

Fixed by enabling "used_linker" feature of linkme.

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 7390705 Feb 1, 2024
27 of 28 checks passed
@wangrunji0408 wangrunji0408 deleted the wrj/linkme branch February 1, 2024 06:14
@cyliu0 cyliu0 mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BugenZhao BugenZhao BugenZhao approved these changes

@TennyZhuang TennyZhuang TennyZhuang approved these changes

Assignees
No one assigned
Labels
type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wangrunji0408 @BugenZhao @TennyZhuang