Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DotAPI missing null check for associated buff #324

Closed
Priscillalala opened this issue Dec 15, 2021 · 1 comment
Closed

DotAPI missing null check for associated buff #324

Priscillalala opened this issue Dec 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@Priscillalala
Copy link
Contributor

A damage over time with a null associated buff fails to register. DotAPI tries to log the associated buff's name without checking if the BuffDef exists. Some vanilla damage over times like Helfire Tincture function without an associated buff.
@Nebby1999 Nebby1999 mentioned this issue Dec 15, 2021
Merged
@Nebby1999
Copy link
Contributor

This is fixed in PR #325 now. it should hopefully release alongside the next update.

@harbingerofme harbingerofme added bug Something isn't working merge pending Issue is fixed in a pull request labels Dec 15, 2021
@tristanmcpherson tristanmcpherson removed the merge pending Issue is fixed in a pull request label Feb 9, 2022
@Nebby1999 Nebby1999 mentioned this issue Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tristanmcpherson @harbingerofme @Nebby1999 @Priscillalala