fix(clusters): switch from drain to ineligible system #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 29, 2024
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @MasterPtato and the rest of your teammates on |
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal
branch
from
7213122 to
0b5bd70
Compare
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal_split
branch
from
a315490 to
612136a
Compare
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal
branch
from
0b5bd70 to
f5e78f6
Compare
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal_split
branch
from
612136a to
f526f3a
Compare
This was referenced Aug 29, 2024
NathanFlurry
approved these changes
Sep 3, 2024
| @@ -67,13 +67,11 @@ async fn undrain_node(ctx: &ActivityCtx, input: &UndrainNodeInput) -> GlobalResu | |||
| .await?; | |||
|
|
|||
| if let Some(nomad_node_id) = nomad_node_id { | |||
There was a problem hiding this comment.
updating this activity on existing ndoes is going to cause a bug where they'll be stuck with the nomad drain enabled. probably best to just manually resolve this when we update.
This was referenced Sep 3, 2024
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> Fixes RVTEE-574 **Manually tested** ## Changes <!-- If there are frontend changes, please include screenshots. -->
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal
branch
from
f5e78f6 to
c117224
Compare
MasterPtato
force-pushed
the
08-28-fix_clusters_remove_nomad_drain_complete_signal_split
branch
from
f526f3a to
09f5143
Compare
Base automatically changed from
08-28-fix_clusters_remove_nomad_drain_complete_signal
to
main
September 3, 2024 23:06
graphite-app
bot
deleted the
08-28-fix_clusters_remove_nomad_drain_complete_signal_split
branch
This was referenced Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes RVTEE-574
Manually tested
Changes