feat(pegboard): add process monitoring, wip sqlite #1146

MasterPtato · 2024-09-13T00:50:13Z

Fixes RVTEE-608

Changes

graphite-app · 2024-09-13T00:50:20Z

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

MasterPtato · 2024-09-13T00:50:35Z

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MasterPtato and the rest of your teammates on Graphite

linear · 2024-09-13T00:50:51Z

RVTEE-608

NathanFlurry · 2024-10-04T23:24:10Z

lib/pegboard/manager/src/utils.rs

+	Ok((watcher, rx))
+}
+
+pub async fn wait_for_creation<P: AsRef<Path>>(path: P) -> Result<()> {


make sure the systemd service has enough watchers configured. write the calculation in the comments (i.e. supports X containers * Y watchers per container) and comment in this func to update the systemd watcher count too

NathanFlurry · 2024-10-04T23:24:47Z

lib/pegboard/manager/src/utils.rs

+				use sqlx::Error::*;
+
+				if i > MAX_QUERY_RETRIES {
+					bail!("max sql retries: {err}");


where do these errors get written & monitored? we need to be able to catch every tiny issue with pb monitors

Was planning on having vector pick up the logs from the manager and stream them to the backend. Didn't get to it for MVP I don't think

NathanFlurry · 2024-10-04T23:28:31Z

lib/pegboard/manager/src/ctx.rs

+		}
+	}
+
+	async fn send_packet(&self, packet: protocol::ToServer) -> Result<()> {


what happens on failure? how are all socket close edge cases handled/

the manager errors then restarts and reconnects to the ws

NathanFlurry · 2024-10-04T23:29:04Z

lib/pegboard/manager/src/ctx.rs

+	async fn write_event(&self, event: &protocol::Event) -> Result<()> {
+		// Write event to db
+		let event_json = serde_json::to_vec(event)?;
+		utils::query(|| async {


how is this edge case failure handled?

which failure? the serde_json::to_vec?

NathanFlurry · 2024-10-04T23:29:51Z

lib/pegboard/manager/src/main.rs

-use client::Client;
+use ctx::Ctx;
+
+const PROTOCOL_VERSION: u16 = 1;

 #[tokio::main]


should we use a current threaded scheduler or limit the threads to 2? this is currently multithreaded, will spin up a lot of excess threads.

we do the same in the toolchain

idk how much parallelism we'll actually need

merge'o'clock

graphite-app · 2024-10-09T04:41:53Z

Merge activity

Oct 9, 12:41 AM EDT: NathanFlurry added this pull request to the Graphite merge queue.
Oct 9, 12:44 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #1141.
Oct 9, 12:45 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #1141.
Oct 9, 12:46 AM EDT: NathanFlurry added this pull request to the Graphite merge queue.
Oct 9, 12:48 AM EDT: CI is running for this PR on a draft PR: #1204
Oct 9, 12:50 AM EDT: NathanFlurry merged this pull request with the Graphite merge queue via draft PR: #1204.

Fixes RVTEE-608 ## Changes

This was referenced Sep 13, 2024

feat(pegboard): implement ws wf #1141

Closed

fix(workflows): filter messages by tags #1142

Closed

feat(pegboard): add client wf #1143

Closed

feat(pegboard): add container runner and manager #1144

Closed

MasterPtato mentioned this pull request Sep 13, 2024

feat(pegboard): add ws tunnel #1145

Closed

This was referenced Sep 13, 2024

feat(pegboard): integrate setup scripts #1147

Closed

feat(pegboard): make protocol more robust, implement db sync #1148

Closed

MasterPtato force-pushed the 09-12-feat_pegboard_add_ws_tunnel branch from c3855c3 to 0d527ab Compare September 14, 2024 01:38

MasterPtato force-pushed the 09-13-feat_pegboard_add_process_monitoring_wip_sqlite branch from 81dbbe7 to d3132bc Compare September 14, 2024 01:39

This was referenced Sep 24, 2024

chore(bolt): make cluster optional #1164

Closed

feat(pegboard): get container connection e2e #1165

Closed

MasterPtato marked this pull request as ready for review September 25, 2024 02:26

MasterPtato requested a review from NathanFlurry September 25, 2024 02:26

MasterPtato mentioned this pull request Sep 27, 2024

feat(pegboard): create robust testing system #1171

Closed

MasterPtato force-pushed the 09-12-feat_pegboard_add_ws_tunnel branch from 0d527ab to 9b3c0cd Compare September 28, 2024 00:24

MasterPtato force-pushed the 09-13-feat_pegboard_add_process_monitoring_wip_sqlite branch from d3132bc to 92504c4 Compare September 28, 2024 00:24

MasterPtato force-pushed the 09-12-feat_pegboard_add_ws_tunnel branch from 9b3c0cd to 7920edb Compare September 29, 2024 21:46

MasterPtato force-pushed the 09-13-feat_pegboard_add_process_monitoring_wip_sqlite branch from 92504c4 to 36cebf1 Compare September 29, 2024 21:46

feat(pegboard): add process monitoring, wip sqlite

281896a

MasterPtato force-pushed the 09-12-feat_pegboard_add_ws_tunnel branch from 7920edb to c5a2d95 Compare October 1, 2024 18:08

MasterPtato force-pushed the 09-13-feat_pegboard_add_process_monitoring_wip_sqlite branch from 36cebf1 to 281896a Compare October 1, 2024 18:09

This was referenced Oct 1, 2024

chore(workflows): tidy up internals #1199

Closed

chore: misc #1200

Closed

NathanFlurry previously requested changes Oct 4, 2024

View reviewed changes

MasterPtato mentioned this pull request Oct 5, 2024

feat(workflows): add workflow migrations #1203

Closed

graphite-app bot closed this Oct 9, 2024

graphite-app bot deleted the 09-13-feat_pegboard_add_process_monitoring_wip_sqlite branch October 9, 2024 04:50

github-actions bot mentioned this pull request Oct 9, 2024

chore(main): release 24.6.0 #1196

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(pegboard): add process monitoring, wip sqlite #1146

feat(pegboard): add process monitoring, wip sqlite #1146

MasterPtato commented Sep 13, 2024 •

edited

Loading

graphite-app bot commented Sep 13, 2024

MasterPtato commented Sep 13, 2024 •

edited

Loading

linear bot commented Sep 13, 2024

NathanFlurry Oct 4, 2024

NathanFlurry Oct 4, 2024

MasterPtato Oct 9, 2024

NathanFlurry Oct 4, 2024

MasterPtato Oct 10, 2024

NathanFlurry Oct 4, 2024

MasterPtato Oct 10, 2024

NathanFlurry Oct 4, 2024

NathanFlurry Oct 4, 2024

NathanFlurry Oct 4, 2024

graphite-app bot commented Oct 9, 2024 •

edited

Loading

feat(pegboard): add process monitoring, wip sqlite #1146

feat(pegboard): add process monitoring, wip sqlite #1146

Conversation

MasterPtato commented Sep 13, 2024 • edited Loading

Changes

graphite-app bot commented Sep 13, 2024

Your org requires the Graphite merge queue for merging into main

MasterPtato commented Sep 13, 2024 • edited Loading

linear bot commented Sep 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

graphite-app bot commented Oct 9, 2024 • edited Loading

Merge activity

MasterPtato commented Sep 13, 2024 •

edited

Loading

MasterPtato commented Sep 13, 2024 •

edited

Loading

graphite-app bot commented Oct 9, 2024 •

edited

Loading