feat(pegboard): integrate setup scripts #1147
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This was referenced Sep 13, 2024
This was referenced Sep 13, 2024
MasterPtato
force-pushed
the
09-13-feat_pegboard_add_process_monitoring_wip_sqlite
branch
from
81dbbe7 to
d3132bc
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_integrate_setup_scripts
branch
from
49eba8f to
c939a61
Compare
This was referenced Sep 16, 2024
This was referenced Sep 24, 2024
MasterPtato
force-pushed
the
09-13-feat_pegboard_add_process_monitoring_wip_sqlite
branch
from
d3132bc to
92504c4
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_integrate_setup_scripts
branch
from
c939a61 to
c873078
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_add_process_monitoring_wip_sqlite
branch
from
92504c4 to
36cebf1
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_integrate_setup_scripts
branch
from
c873078 to
3fed967
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_add_process_monitoring_wip_sqlite
branch
from
36cebf1 to
281896a
Compare
MasterPtato
force-pushed
the
09-13-feat_pegboard_integrate_setup_scripts
branch
from
3fed967 to
2d06c72
Compare
This was referenced Oct 1, 2024
Closed
NathanFlurry
reviewed
Oct 4, 2024
| @@ -33,6 +33,12 @@ fn main() -> anyhow::Result<()> { | |||
| .context("`container_dir` arg required")?; | |||
| let pegboard_container_dir = Path::new(&pegboard_container_dir); | |||
|
|
|||
| // Write PID to file | |||
| fs::write( | |||
| pegboard_container_dir.join("pid"), | |||
There was a problem hiding this comment.
nit: use consts for all files that are written. makes it easy to know what's in the folder
There was a problem hiding this comment.
could you elaborate?
NathanFlurry
reviewed
Oct 4, 2024
| @@ -207,6 +226,8 @@ impl Ctx { | |||
| // Check file doesn't exist | |||
| if fs::metadata(&path).await.is_err() { | |||
| utils::download_file(container_runner_binary_url, &path).await?; | |||
|
|
|||
| Command::new("chmod").arg("+x").arg(&path).output().await?; | |||
Merge activity
|
NathanFlurry
pushed a commit
that referenced
this pull request
Oct 9, 2024
<!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
graphite-app
bot
deleted the
09-13-feat_pegboard_integrate_setup_scripts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes