Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add put and delete ops to kv #1325

Closed
wants to merge 1 commit into from
Closed

feat: add put and delete ops to kv #1325

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 58322ba
Status:🚫  Build failed.

View logs

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Nov 8, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Nov 8, 2024
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Nov 8, 2024 •
edited by NathanFlurry
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Nov 8, 2024
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from d143f31 to 741ae58 Compare November 9, 2024 08:33
@NathanFlurry NathanFlurry force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 85ebff2 to e25118e Compare November 9, 2024 08:34
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 741ae58 to a824159 Compare November 11, 2024 20:06
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from e25118e to b4e3120 Compare November 11, 2024 20:06
@MasterPtato MasterPtato marked this pull request as ready for review November 11, 2024 21:29
@MasterPtato MasterPtato mentioned this pull request Nov 13, 2024
Closed
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from a824159 to 9ee2eed Compare November 13, 2024 19:19
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from b4e3120 to c4b66e2 Compare November 13, 2024 19:19
This was referenced Nov 14, 2024
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 9ee2eed to 0ddcd1f Compare November 15, 2024 02:00
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from c4b66e2 to e67371f Compare November 15, 2024 02:00
This was referenced Nov 15, 2024
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 0ddcd1f to 7aa0639 Compare November 19, 2024 19:14
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from e67371f to 31e4ca3 Compare November 19, 2024 19:14
@MasterPtato MasterPtato mentioned this pull request Nov 19, 2024
Closed
@MasterPtato MasterPtato mentioned this pull request Nov 20, 2024
Closed
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 7aa0639 to ee8c2e1 Compare November 20, 2024 18:57
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 31e4ca3 to fec751b Compare November 20, 2024 18:57
This was referenced Nov 20, 2024
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from ee8c2e1 to e984896 Compare November 20, 2024 19:26
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from fec751b to 35e0eea Compare November 20, 2024 19:26
@NathanFlurry NathanFlurry force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from e984896 to 3623ffe Compare November 21, 2024 01:48
@NathanFlurry NathanFlurry force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 35e0eea to 14db016 Compare November 21, 2024 01:48
@NathanFlurry NathanFlurry force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 3623ffe to 964ab8c Compare November 21, 2024 01:57
@NathanFlurry NathanFlurry force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 14db016 to 0ce4f25 Compare November 21, 2024 01:57
NathanFlurry
NathanFlurry approved these changes Nov 21, 2024
View reviewed changes
packages/infra/client/isolate-v8-runner/src/ext/kv.rs

let existed = db
.run(|tx, _maybe_committed| async move {
let existed = tx.get(bkey, false).await?.is_some();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking we should get rid of the bool in the response and just run clear. goal is to map kv as close to fdb as possible with as little overhead. thoughts?

NathanFlurry
NathanFlurry previously requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops mean to request changes, see comment

@MasterPtato MasterPtato force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 964ab8c to 4c97cb2 Compare November 21, 2024 02:41
@MasterPtato MasterPtato force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 0ce4f25 to 2a4c72d Compare November 21, 2024 02:41
@MasterPtato MasterPtato mentioned this pull request Nov 21, 2024
Closed
@NathanFlurry NathanFlurry force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from 4c97cb2 to c8e700d Compare November 21, 2024 09:10
@NathanFlurry NathanFlurry force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 2a4c72d to 3d1f602 Compare November 21, 2024 09:10
@NathanFlurry NathanFlurry force-pushed the 11-07-feat_add_kv_get_ext_fix_runtime_termination branch from c8e700d to 34b33ed Compare November 21, 2024 20:52
@NathanFlurry NathanFlurry force-pushed the 11-08-feat_add_put_and_delete_ops_to_kv branch from 3d1f602 to 58322ba Compare November 21, 2024 20:52
@NathanFlurry NathanFlurry mentioned this pull request Nov 21, 2024
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Nov 21, 2024 •
edited
Loading

Merge activity

  • Nov 21, 3:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 3:58 PM EST: CI is running for this PR on a draft PR: #1425
  • Nov 21, 4:00 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1425.

NathanFlurry pushed a commit that referenced this pull request Nov 21, 2024
@MasterPtato
feat: add put and delete ops to kv (#1325)
bc65b95 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot deleted the branch 11-07-feat_add_kv_get_ext_fix_runtime_termination November 21, 2024 21:00
@graphite-app graphite-app bot closed this Nov 21, 2024
@graphite-app graphite-app bot closed this Nov 21, 2024
@graphite-app graphite-app bot deleted the 11-08-feat_add_put_and_delete_ops_to_kv branch November 21, 2024 21:00
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry