Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: get pegboard -> fdb connection over vlan #1362

Closed
wants to merge 1 commit into from
Closed

fix: get pegboard -> fdb connection over vlan #1362

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 15, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 845a4cb
Status:🚫  Build failed.

View logs

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Nov 15, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

This was referenced Nov 15, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato Graphite App
Copy link
Contributor Author

MasterPtato commented Nov 15, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato mentioned this pull request Nov 15, 2024
Closed
@MasterPtato MasterPtato force-pushed the 11-14-fix_fix_various_bugs branch from fc6d524 to a22e331 Compare November 15, 2024 02:01
@MasterPtato MasterPtato force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 805762f to e84698f Compare November 15, 2024 02:01
This was referenced Nov 15, 2024
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-14-fix_fix_various_bugs branch from a22e331 to b29adf9 Compare November 19, 2024 19:15
@MasterPtato MasterPtato force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from e84698f to 1e01855 Compare November 19, 2024 19:15
This was referenced Nov 19, 2024
Closed
Closed
Closed
Closed
Closed
Closed
@MasterPtato MasterPtato force-pushed the 11-14-fix_fix_various_bugs branch from b29adf9 to eebc22b Compare November 20, 2024 18:58
@MasterPtato MasterPtato force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 1e01855 to a48393f Compare November 20, 2024 18:58
@MasterPtato MasterPtato force-pushed the 11-14-fix_fix_various_bugs branch from eebc22b to 76b6459 Compare November 20, 2024 19:27
@MasterPtato MasterPtato force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from a48393f to c945a67 Compare November 20, 2024 19:27
@NathanFlurry NathanFlurry force-pushed the 11-14-fix_fix_various_bugs branch from 76b6459 to c9221e7 Compare November 21, 2024 01:49
@NathanFlurry NathanFlurry force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from c945a67 to 46cdc4a Compare November 21, 2024 01:49
@NathanFlurry NathanFlurry force-pushed the 11-14-fix_fix_various_bugs branch from c9221e7 to 3415ead Compare November 21, 2024 02:00
@NathanFlurry NathanFlurry force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 46cdc4a to 2218134 Compare November 21, 2024 02:01
@MasterPtato MasterPtato force-pushed the 11-14-fix_fix_various_bugs branch from 3415ead to f10e5a2 Compare November 21, 2024 02:42
@MasterPtato MasterPtato force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 2218134 to 1f4e131 Compare November 21, 2024 02:42
@MasterPtato MasterPtato mentioned this pull request Nov 21, 2024
Closed
NathanFlurry
NathanFlurry previously requested changes Nov 21, 2024
View reviewed changes
packages/services/build/standalone/default-create/src/lib.rs
@@ -97,7 +97,7 @@ async fn upload_build(
backend::upload::PrepareFile {
path: unwrap!(unwrap!(build.key.file_name(), "should have file name").to_str()).to_string(),
content_length: len,
multipart: false,
multipart: len > util::file_size::mebibytes(100),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i updated upload prepare to automatically handle this

rivet/packages/services/upload/ops/prepare/src/lib.rs

Line 255 in eaee5a5

return Ok(handle_upload(s3_client, upload_id, file).await?);

@NathanFlurry NathanFlurry force-pushed the 11-14-fix_fix_various_bugs branch from f10e5a2 to 1db70ca Compare November 21, 2024 09:11
@NathanFlurry NathanFlurry force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 1f4e131 to 07f359e Compare November 21, 2024 09:11
@NathanFlurry NathanFlurry force-pushed the 11-14-fix_fix_various_bugs branch from 1db70ca to bf66349 Compare November 21, 2024 20:53
@NathanFlurry NathanFlurry force-pushed the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch from 07f359e to 845a4cb Compare November 21, 2024 20:53
@NathanFlurry NathanFlurry mentioned this pull request Nov 21, 2024
Closed
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Nov 21, 2024 •
edited
Loading

Merge activity

  • Nov 21, 3:55 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 21, 3:58 PM EST: CI is running for this PR on a draft PR: #1425
  • Nov 21, 4:00 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1425.

NathanFlurry pushed a commit that referenced this pull request Nov 21, 2024
@MasterPtato
fix: get pegboard -> fdb connection over vlan (#1362)
12f01f7 
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Nov 21, 2024
@graphite-app graphite-app bot deleted the 11-15-fix_get_pegboard_-_fdb_connection_over_vlan branch November 21, 2024 21:00
@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry