Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix event sending race condition for pb manager #1455

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Nov 23, 2024

Fixes RVT-4174

Changes

Copy link

cloudflare-workers-and-pages bot commented Nov 23, 2024

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: b582494
Status: ✅  Deploy successful!
Preview URL: https://c3342e97.rivet.pages.dev
Branch Preview URL: https://11-23-fix-fix-event-sending.rivet.pages.dev

View logs

Copy link
Contributor

graphite-app bot commented Nov 23, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato MasterPtato force-pushed the 11-23-fix_fix_event_sending_race_condition_for_pb_manager branch 2 times, most recently from 651d676 to 97bf652 Compare November 23, 2024 02:34
@MasterPtato MasterPtato marked this pull request as ready for review November 23, 2024 02:34
@MasterPtato MasterPtato force-pushed the 11-23-fix_fix_event_sending_race_condition_for_pb_manager branch from 97bf652 to 1f67c76 Compare November 23, 2024 02:34
Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to update rivet-client in both dev-full and monolith for fdb change

authors.workspace = true
license.workspace = true
edition.workspace = true
version = "0.0.1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert to use workspaces

@NathanFlurry NathanFlurry force-pushed the 11-23-fix_fix_event_sending_race_condition_for_pb_manager branch from 1f67c76 to b582494 Compare November 23, 2024 15:15
@NathanFlurry NathanFlurry force-pushed the 11-23-fix_fix_event_sending_race_condition_for_pb_manager branch from b582494 to 879ec1f Compare November 23, 2024 15:15
NathanFlurry pushed a commit that referenced this pull request Nov 23, 2024
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
Copy link
Contributor

graphite-app bot commented Nov 23, 2024

Merge activity

  • Nov 23, 10:33 AM EST: CI is running for this PR on a draft PR: #1460
  • Nov 23, 10:38 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1460.

@graphite-app graphite-app bot closed this Nov 23, 2024
@graphite-app graphite-app bot deleted the 11-23-fix_fix_event_sending_race_condition_for_pb_manager branch November 23, 2024 15:38
Copy link

linear bot commented Nov 26, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants