Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make isolate runtime local #1517

Closed
wants to merge 1 commit into from
Closed

fix: make isolate runtime local #1517

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Dec 3, 2024 •
edited
Loading

Fixes RVT-4265

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: e5f88d5
Status: ✅  Deploy successful!
Preview URL: https://73a1b9ca.rivet.pages.dev
Branch Preview URL: https://12-02-fix-make-isolate-runti.rivet.pages.dev

View logs

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 3, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MasterPtato Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@linear Linear
Copy link

linear bot commented Dec 3, 2024

RVT-4265 Remove global scope in favor of `start`

@MasterPtato MasterPtato force-pushed the 12-02-fix_make_isolate_runtime_local branch from 8073aad to b26a819 Compare December 3, 2024 21:43
@MasterPtato MasterPtato marked this pull request as ready for review December 3, 2024 21:43
@MasterPtato Graphite App
Copy link
Contributor Author

@NathanFlurry might need some changes to the actor sdk, i tried fixing it myself

@MasterPtato MasterPtato force-pushed the 12-02-fix_make_isolate_runtime_local branch from b26a819 to dd3c1c2 Compare December 3, 2024 22:07
@MasterPtato MasterPtato force-pushed the 12-02-fix_make_isolate_runtime_local branch from dd3c1c2 to e5f88d5 Compare December 3, 2024 22:08
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 4, 8:49 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 4, 8:49 PM EST: CI is running for this PR on a draft PR: #1526
  • Dec 4, 8:54 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1526.

NathanFlurry pushed a commit that referenced this pull request Dec 5, 2024
@MasterPtato
fix: make isolate runtime local (#1517)
8a8b8a2 
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4265
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Dec 5, 2024
@graphite-app graphite-app bot deleted the 12-02-fix_make_isolate_runtime_local branch December 5, 2024 01:54
@github-actions github-actions bot mentioned this pull request Dec 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry