-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update architecture diagram #1521
Conversation
Deploying rivet with Cloudflare Pages
|
Your org requires the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some notes on figma
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left some notes on figma. also needs to be included in docs under actor internal. (might just rename to internals)
revised figma |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
left a few couple comments.
let's add an architecture diagram page under advanced > internal
in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.
nit: let's use png export since it's lossless.
Do we need it to be lossess? Its also a massive image file |
@NathanFlurry revised again |
My export was 404 kb. PNG is really good at compression. |
32cfcf4
to
22f8e71
Compare
Merge activity
|
<!-- Please make sure there is an issue that this PR is correlated to. --> Fixes RVT-4055 ## Changes <!-- If there are frontend changes, please include screenshots. -->
Fixes RVT-4055
Changes