Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update architecture diagram #1521

Closed
wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Dec 4, 2024

Fixes RVT-4055

Changes

Copy link

cloudflare-workers-and-pages bot commented Dec 4, 2024

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 22f8e71
Status: ✅  Deploy successful!
Preview URL: https://f4487cd8.rivet.pages.dev
Branch Preview URL: https://12-04-fix-update-architectur.rivet.pages.dev

View logs

Copy link
Contributor

graphite-app bot commented Dec 4, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

linear bot commented Dec 4, 2024

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some notes on figma

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some notes on figma. also needs to be included in docs under actor internal. (might just rename to internals)

Copy link
Contributor Author

revised figma

Copy link
Member

@NathanFlurry NathanFlurry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a few couple comments.

let's add an architecture diagram page under advanced > internal in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.

nit: let's use png export since it's lossless.

Copy link
Contributor Author

left a few couple comments.

let's add an architecture diagram page under advanced > internal in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.

nit: let's use png export since it's lossless.

Do we need it to be lossess? Its also a massive image file

Copy link
Contributor Author

@NathanFlurry revised again

Copy link
Member

left a few couple comments.

let's add an architecture diagram page under advanced > internal in the docs too. you can link directly to the architecture image file from the readme so we don't have to dupe it.

nit: let's use png export since it's lossless.

Do we need it to be lossess? Its also a massive image file

My export was 404 kb. PNG is really good at compression.

@NathanFlurry NathanFlurry force-pushed the 12-04-fix_update_architecture_diagram branch from 32cfcf4 to 22f8e71 Compare December 10, 2024 05:18
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Merge activity

  • Dec 10, 12:32 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 12:45 AM EST: CI is running for this PR on a draft PR: #1568
  • Dec 10, 1:23 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1568.

NathanFlurry pushed a commit that referenced this pull request Dec 10, 2024
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4055
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-04-fix_update_architecture_diagram branch December 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants