Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fancy subnav #1537

Closed
wants to merge 1 commit into from
Closed

Conversation

jog1t
Copy link
Contributor

@jog1t jog1t commented Dec 5, 2024

Changes

Copy link

cloudflare-workers-and-pages bot commented Dec 5, 2024

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3196fb
Status:⚡️  Build in progress...

View logs

Copy link
Contributor

graphite-app bot commented Dec 5, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@jog1t jog1t mentioned this pull request Dec 5, 2024
Copy link
Contributor Author

jog1t commented Dec 5, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jog1t jog1t force-pushed the 12-04-refactor_docs_framer_cleanup branch from 6b3b254 to 2bc9a19 Compare December 9, 2024 16:53
@jog1t jog1t force-pushed the 12-05-feat_fancy_subnav branch from aca917f to bca076d Compare December 9, 2024 16:53
@NathanFlurry NathanFlurry changed the base branch from 12-04-refactor_docs_framer_cleanup to graphite-base/1537 December 10, 2024 23:26
@jog1t jog1t force-pushed the graphite-base/1537 branch from 2bc9a19 to 5daa00e Compare December 12, 2024 21:57
@jog1t jog1t force-pushed the 12-05-feat_fancy_subnav branch from bca076d to 74b010f Compare December 12, 2024 21:57
@jog1t jog1t changed the base branch from graphite-base/1537 to main December 12, 2024 21:57
@jog1t jog1t force-pushed the 12-05-feat_fancy_subnav branch 2 times, most recently from 99a7996 to 833210e Compare December 13, 2024 20:10
@jog1t jog1t requested a review from NicholasKissel December 13, 2024 21:05
@jog1t jog1t self-assigned this Dec 13, 2024
@jog1t jog1t force-pushed the 12-05-feat_fancy_subnav branch 3 times, most recently from 68252cc to 8c1ca51 Compare December 13, 2024 21:46
Copy link
Member

@NicholasKissel NicholasKissel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image.png

Alignment and the slide in left/right transition between solutions and product being changed out to something more subtle

@NathanFlurry NathanFlurry force-pushed the 12-05-feat_fancy_subnav branch from da6c105 to e3196fb Compare December 20, 2024 10:28
@NathanFlurry NathanFlurry changed the base branch from main to 12-20-chore_move_docs_-_site_and_add_docs_symlink December 20, 2024 10:28
@NathanFlurry NathanFlurry marked this pull request as ready for review December 20, 2024 10:28
Copy link
Contributor

graphite-app bot commented Dec 20, 2024

Merge activity

  • Dec 20, 5:45 AM EST: A user added this pull request to the Graphite merge queue.
  • Dec 20, 5:46 AM EST: CI is running for this PR on a draft PR: #1668
  • Dec 20, 6:58 AM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1668.

@NathanFlurry NathanFlurry changed the base branch from 12-20-chore_move_docs_-_site_and_add_docs_symlink to graphite-base/1537 December 20, 2024 10:45
NathanFlurry pushed a commit that referenced this pull request Dec 20, 2024
<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Dec 20, 2024
@graphite-app graphite-app bot deleted the 12-05-feat_fancy_subnav branch December 20, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants