Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add path-based routing for actors & add rg to docker compose #1548

Closed
wants to merge 2 commits into from
Closed

chore: add path-based routing for actors & add rg to docker compose #1548

wants to merge 2 commits into from

Conversation

NathanFlurry
Copy link
Member

Fixes RVT-4331

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 6, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5f20a87
Status:🚫  Build failed.

View logs

@linear Linear
Copy link

linear bot commented Dec 6, 2024

RVT-4331 Implement OSS GG

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 6, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@NathanFlurry NathanFlurry marked this pull request as draft December 6, 2024 23:54
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Dec 6, 2024 •
edited
Loading

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@NathanFlurry NathanFlurry changed the title chore: add path-based routing for actors chore: add path-based routing for actors & add gg to docker compose Dec 6, 2024
@NathanFlurry NathanFlurry changed the title chore: add path-based routing for actors & add gg to docker compose chore: add path-based routing for actors & add rg to docker compose Dec 6, 2024
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 3 times, most recently from 487dd79 to 09235ea Compare December 8, 2024 01:06
@NathanFlurry NathanFlurry marked this pull request as ready for review December 9, 2024 22:02
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 2 times, most recently from f51c3f1 to e927fcd Compare December 10, 2024 04:48
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 10, 2024 •
edited
Loading

Merge activity

  • Dec 9, 11:53 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 9, 11:53 PM EST: CI is running for this PR on a draft PR: #1563
  • Dec 9, 11:58 PM EST: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI (cargo-check-main)).
  • Dec 10, 10:17 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 10, 10:19 PM EST: The Graphite merge queue couldn't merge this PR because it had conflicts with the trunk branch.
  • Dec 11, 2:37 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 11, 2:38 PM EST: CI is running for this PR on a draft PR: #1594
  • Dec 11, 2:50 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1594.

NathanFlurry added a commit that referenced this pull request Dec 10, 2024
@NathanFlurry
chore: add path-based routing for actors & add rg to docker compose (#…
cd9c9c9 
…1548)

Fixes RVT-4331
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 3 times, most recently from 208db25 to 0aef551 Compare December 10, 2024 07:00
MasterPtato
MasterPtato requested changes Dec 10, 2024
View reviewed changes
packages/api/provision/src/route/servers.rs Outdated Show resolved Hide resolved
packages/services/cluster/src/types.rs Outdated Show resolved Hide resolved
packages/services/ds/src/workflows/server/mod.rs Outdated Show resolved Hide resolved
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 3 times, most recently from ca7c131 to 2c08778 Compare December 10, 2024 20:27
MasterPtato
MasterPtato previously requested changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment, otherwise lgtm

@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 2 times, most recently from 91896a2 to 7d6adcc Compare December 10, 2024 20:59
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch 2 times, most recently from 23077ce to 432000f Compare December 11, 2024 03:06
@NathanFlurry NathanFlurry mentioned this pull request Dec 11, 2024
Closed
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch from 432000f to 5939a3f Compare December 11, 2024 03:28
This was referenced Dec 11, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 12-06-chore_add_path-based_routing_for_actors branch from 5939a3f to 5f20a87 Compare December 11, 2024 19:26
NathanFlurry added a commit that referenced this pull request Dec 11, 2024
@NathanFlurry
chore: add path-based routing for actors & add rg to docker compose (#…
cf8acc9 
…1548)

Fixes RVT-4331
@graphite-app graphite-app bot closed this Dec 11, 2024
@graphite-app graphite-app bot deleted the 12-06-chore_add_path-based_routing_for_actors branch December 11, 2024 19:50
@github-actions github-actions bot mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato