Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add check_version to wf #1560

Closed
wants to merge 1 commit into from
Closed

feat: add check_version to wf #1560

wants to merge 1 commit into from

Conversation

MasterPtato
Copy link
Contributor

@MasterPtato MasterPtato commented Dec 10, 2024 •
edited
Loading

Fixes RVT-4340

Changes

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 10, 2024 •
edited
Loading

Deploying rivet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4bbf0d7
Status: ✅  Deploy successful!
Preview URL: https://284588b3.rivet.pages.dev
Branch Preview URL: https://12-10-feat-add-check-version.rivet.pages.dev

View logs

@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 10, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MasterPtato Graphite App
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MasterPtato Graphite App
Copy link
Contributor Author

@NathanFlurry this currently implements both ctx.check_version(n) and ctx.v(n).check_version(). should we keep both or just one?

@linear Linear
Copy link

linear bot commented Dec 10, 2024

RVT-4340 Change syntax to ctx.is_version(n) for easier use

@MasterPtato MasterPtato force-pushed the 12-10-feat_add_check_version_to_wf branch from 58abba7 to 70ff44a Compare December 10, 2024 02:49
@MasterPtato MasterPtato force-pushed the 12-10-feat_add_check_version_to_wf branch from 70ff44a to 4bbf0d7 Compare December 10, 2024 03:25
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Dec 10, 2024 •
edited
Loading

Merge activity

  • Dec 9, 11:49 PM EST: A user added this pull request to the Graphite merge queue.
  • Dec 9, 11:50 PM EST: CI is running for this PR on a draft PR: #1561
  • Dec 9, 11:55 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #1561.

NathanFlurry pushed a commit that referenced this pull request Dec 10, 2024
@MasterPtato
feat: add check_version to wf (#1560)
a3c99f8 
<!-- Please make sure there is an issue that this PR is correlated to. -->
Fixes RVT-4340
## Changes

<!-- If there are frontend changes, please include screenshots. -->
@graphite-app graphite-app bot closed this Dec 10, 2024
@graphite-app graphite-app bot deleted the 12-10-feat_add_check_version_to_wf branch December 10, 2024 04:55
@github-actions github-actions bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NathanFlurry NathanFlurry NathanFlurry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterPtato @NathanFlurry