fix(mm): correctly handle lobby not found error if joining direclty to lobby id that doesn't exist #867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainYou must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. You can enable merging using labels in your Graphite merge queue settings. |
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @NathanFlurry and the rest of your teammates on |
This was referenced Jun 6, 2024
Merge activity
|
…o lobby id that doesn't exist (#867) <!-- Please make sure there is an issue that this PR is correlated to. --> ## Changes <!-- If there are frontend changes, please include screenshots. -->
NathanFlurry
force-pushed
the
06-05-fix_mm_call_mm-lobby-cleanup_from_mm-gc_even_for_preemptive_lobbies_without_sql_row
branch
from
c9aa4c5 to
5315a9a
Compare
NathanFlurry
force-pushed
the
06-05-fix_mm_correctly_handle_lobby_not_found_error_if_joining_direclty_to_lobby_id_that_doesn_t_exist
branch
from
24fdc37 to
af3513a
Compare
NathanFlurry
changed the base branch from
06-05-fix_mm_call_mm-lobby-cleanup_from_mm-gc_even_for_preemptive_lobbies_without_sql_row
to
main
graphite-app
bot
deleted the
06-05-fix_mm_correctly_handle_lobby_not_found_error_if_joining_direclty_to_lobby_id_that_doesn_t_exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes