Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(infra): dynamically generate nomad server count in install script #981

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(infra): dynamically generate nomad server count in install script #981

merged 1 commit into from
Jul 23, 2024

Conversation

NathanFlurry
Copy link
Member

Changes

@NathanFlurry NathanFlurry requested a review from MasterPtato July 3, 2024 06:55
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jul 3, 2024

Your org requires the Graphite merge queue for merging into main

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

You can enable merging using labels in your Graphite merge queue settings.

@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2024
Merged
@NathanFlurry Graphite App
Copy link
Member Author

NathanFlurry commented Jul 3, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @NathanFlurry and the rest of your teammates on Graphite Graphite

@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2024
Merged
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 7d78b2c to 3f903fa Compare July 3, 2024 07:29
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 89c503c to be0c82d Compare July 3, 2024 07:29
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 3f903fa to 1add5e0 Compare July 3, 2024 08:29
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from be0c82d to 76ab24f Compare July 3, 2024 08:29
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 1add5e0 to 1982323 Compare July 3, 2024 08:33
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 76ab24f to 42dc454 Compare July 3, 2024 08:33
This was referenced Jul 3, 2024
Merged
Merged
Merged
Merged
Closed
Closed
Closed
Merged
Closed
Closed
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 1982323 to ec2178d Compare July 3, 2024 08:42
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 42dc454 to e77a4a5 Compare July 3, 2024 08:42
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from ec2178d to d1c1d90 Compare July 3, 2024 09:37
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from e77a4a5 to 3107981 Compare July 3, 2024 09:37
@NathanFlurry NathanFlurry mentioned this pull request Jul 3, 2024
Merged
@AngelOnFira AngelOnFira force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from d1c1d90 to 28895e5 Compare July 4, 2024 00:31
@AngelOnFira AngelOnFira force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 3107981 to a0a2fd0 Compare July 4, 2024 00:31
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 28895e5 to 7c3214f Compare July 4, 2024 18:41
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from a0a2fd0 to 798c01d Compare July 4, 2024 18:41
@NathanFlurry NathanFlurry mentioned this pull request Jul 4, 2024
Merged
@AngelOnFira AngelOnFira force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 7c3214f to c6145ee Compare July 6, 2024 04:19
@AngelOnFira AngelOnFira force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 798c01d to 3b28c6e Compare July 6, 2024 04:19
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from c6145ee to 7c3214f Compare July 6, 2024 17:52
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 3b28c6e to 798c01d Compare July 6, 2024 17:52
MasterPtato
MasterPtato reviewed Jul 9, 2024
View reviewed changes
Copy link
Contributor

@MasterPtato MasterPtato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this what was causing the nomad problems we've been having?

infra/tf/k8s_infra/nomad.tf
#
# This value must be 3, 5, or 7. More = better redundancy, but does not make things faster.
#
# See https://developer.hashicorp.com/nomad/tutorials/enterprise/production-reference-architecture-vm-with-consul
nomad_server_count = var.deploy_method_cluster ? 3 : 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dead variable?

@NathanFlurry NathanFlurry mentioned this pull request Jul 23, 2024
Merged
@graphite-app Graphite App
Copy link
Contributor

graphite-app bot commented Jul 23, 2024 •
edited
Loading

Merge activity

@NathanFlurry
fix(infra): dynamically generate nomad server count in install script (…
9c433d8 
…#981)

<!-- Please make sure there is an issue that this PR is correlated to. -->

## Changes

<!-- If there are frontend changes, please include screenshots. -->
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install branch from 7c3214f to 8be472f Compare July 23, 2024 08:12
@NathanFlurry NathanFlurry force-pushed the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch from 798c01d to 9c433d8 Compare July 23, 2024 08:12
@NathanFlurry NathanFlurry changed the base branch from 07-02-fix_infra_pass_dynamic_tunnel_host_port_to_cluster-server-install to main July 23, 2024 08:19
@graphite-app graphite-app bot merged commit 9c433d8 into main Jul 23, 2024
6 of 10 checks passed
@graphite-app graphite-app bot deleted the 07-02-fix_infra_dynamically_generate_nomad_server_count_in_install_script branch July 23, 2024 08:21
@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MasterPtato MasterPtato MasterPtato left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NathanFlurry @MasterPtato