Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in lintr GitHub action #45

Open
AQLT opened this issue Oct 29, 2024 · 2 comments
Open

Error in lintr GitHub action #45

AQLT opened this issue Oct 29, 2024 · 2 comments

Comments

@AQLT
Copy link
Contributor

AQLT commented Oct 29, 2024

I understand that it comes from the fact that the GA uses ubuntu and utils::choose.files only exists in Windows

@TanguyBarthelemy
Copy link
Contributor

Ok, so first of all, the linter issue can be ignored with an added item in the .lintr file.
In the long run, we can add a # nolint tag to the problematic line or create an exclusion in the .lintr file.

@AQLT
Copy link
Contributor Author

AQLT commented Nov 19, 2024

If the issue can be ignored then we should removed the error from the GitHub action for pull request. It can be disturbing to see that every PR failed: in my opinion, the checks in PR should prevent from error in the code and not create false alarm with checks which can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants