Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump antd theme to latest major version #3639

Open
heath-freenome opened this issue May 5, 2023 · 9 comments
Open

Bump antd theme to latest major version #3639

heath-freenome opened this issue May 5, 2023 · 9 comments
Labels
antd antd related theme issue breaking change

Comments

@heath-freenome
Copy link
Member

Antd theme is one major version behind, we are on 4, the latest is 5

@github-actions github-actions bot added the needs triage Initial label given, to be assigned correct labels and assigned label May 5, 2023
@heath-freenome heath-freenome added breaking change antd antd related theme issue and removed needs triage Initial label given, to be assigned correct labels and assigned labels May 5, 2023
@anthonycaron
Copy link
Contributor

anthonycaron commented May 24, 2023

+1 We would like to have it done on our side. Are there any plans to do this soon ? We can help with it I think.

@heath-freenome
Copy link
Member Author

heath-freenome commented May 24, 2023

@anthonycaron Do you know whether this can be done with backwards compatibility to 4.x? If not, we'll have to begin the 6.x plan and have to do it in a beta branch. And any help you can offer would be awesome. There are only 1 or 2 of the main contributors to do all the 6.x work.

@heath-freenome
Copy link
Member Author

Actually someone has taken some time to do the work in response to this issue #3507

@anthonycaron
Copy link
Contributor

Actually someone has taken some time to do the work in response to this issue #3507

Nice then ! You plan to add it to the 6.x beta ?

@koszti
Copy link

koszti commented Jul 21, 2023

wondering if something has changed in the last two month. Has anyone made some progress to support antd 5?

@heath-freenome
Copy link
Member Author

We haven't started the v6 work. Someone has already come up with what seems to be the changes necessary to get it to work with 5.x. If someone wanted to ensure those changes were backwards compatible with 4.x, then we would consider pulling it into the 5.x release of RJSF

@cr8or1
Copy link

cr8or1 commented Aug 10, 2023

@heath-freenome It will be backwards compatible with 4.x We really need the antd 5 to work with RJSF. Can you approve this PR?

@heath-freenome
Copy link
Member Author

@cr8or1 The changes are in fork that we don't control. You are welcome to copy that code into your own fork and push up a PR for us to review and merge. Can you do that?

@Manish3323
Copy link
Contributor

Manish3323 commented Aug 12, 2023

@heath-freenome @cr8or1 i have created a pr (includes changes from fran122157's pr) along with some extra changes to make it look as close as current rjsf playground.

here is link to the pr

Do review, let me know your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
antd antd related theme issue breaking change
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants