oneOf doesn't work with objects

[gabor-meresz-epam]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.x

Current Behavior

The form shows wrong error messages in case the schema contains oneOf with objects inside and the user changes between the available options.

The unexpected errors:

• must NOT have additional properties
• must match exactly one schema in oneOf

Expected Behavior

The form should work fine with all kinds of oneOf schemas.

Steps To Reproduce

1. Go to Playground
2. Enable Live Validation
3. Select 'Option 2'
4. Select 'Option 1'

Environment

RJSF playground

Anything else?

[heath-freenome]

@gabor-meresz-epam Even AJV believes that this is not a valid schema. Have you tried something like this playground instead?

[tamas-grosz-epam]

Hi @heath-freenome , sorry I get 404 on the link you provided
https://rjsf-team.github.io/react-jsonschema-form/

actually, we got that if the oneOf contains an object, then after changing the Option - the validation fails always

[gabor-meresz-epam]

@gabor-meresz-epam Even AJV believes that this is not a valid schema. Have you tried something like this playground instead?

Sorry the link you provided is broken (404)

The schema looks valid for me, I tried out with https://www.jsonschemavalidator.net/

[gabor-meresz-epam]

@heath-freenome did you have a chance to check the replies?

[heath-freenome]

@gabor-meresz-epam Sorry, it's been a busy week at work. I'm trying to figure out what the example I sent was and why the link is broken

[heath-freenome]

Here's the proper Playground link

[tamas-grosz-epam]

hi, @heath-freenome thanks for the new link, it's working now - and it does not give error, but :)
if both branches of oneOf are objects (I added "type": "object" to "Adam" in your example), then pressed Reset, then Validate (it's ok now), then changed the option - and now pressing Validate again brings the error

[heath-freenome]

hi, @heath-freenome thanks for the new link, it's working now - and it does not give error, but :) if both branches of oneOf are objects (I added "type": "object" to "Adam" in your example), then pressed Reset, then Validate (it's ok now), then changed the option - and now pressing Validate again brings the error

Can you share the playground link for the situation you are describing? You can use the Share button and paste what is put into your clipboard

[tamas-grosz-epam]

hi, @heath-freenome , sure - but it's really only that one line
link
It behaves a bit strange: if you play with clicking on reset, validate and changing the option - then sometimes it says ok, sometimes gives errors. To me it seems either a cache like issue, or like the validator wouldn't fall back from the wrong branch.
And is the discriminator always necessary? Couldn't the validator differentiate between branches by their simple content?

[heath-freenome]

The discriminator provides a performance increase with the oneOf computations

[tamas-grosz-epam]

hi, @heath-freenome, back to the original issue: could you reproduce the error from the playground link provided?

[heath-freenome]

@tamas-grosz-epam I could when I removed the trainer prop from the formData. If you change the object fields default behavior then things work fine. See this link

[tamas-grosz-epam]

Hi, @heath-freenome - maybe I didn't notice something, but your link seems to be the same as the first one.
The problem is when both branches are objects, like in the link I gave. I paste it again:
link
It behaves a bit strange: if you play with clicking on reset, validate and changing the option - then sometimes it says ok, sometimes gives errors. To me it seems either a cache like issue, or like the validator wouldn't fall back from the wrong branch.

[heath-freenome]

The link is different, not in the schema, but in the options, specifically the Object fields default behavior

[tamas-grosz-epam]

Hi, sorry for the late reaction. We introduced and tested your idea, it works. This issue may be closed, still I'd prefer to keep it and convert to show that the setting is incompatible with the oneOf part

[heath-freenome]

@tamas-grosz-epam I don't understand your comment. Perhaps you could either update this issue or write a new one with a more specific cause/effect bug for the incompatible oneOf part?

[tamas-grosz-epam]

With your suggestion to change Object fields default behavior option - it works. But without changing it, it does not - that's what I mean incompatible

[heath-freenome]

Ah... Well we provide the options on Form to change the various behaviors of RJSF. If using one of these behavior changes solves your problem, then I believe the issue is solved. As for it being incompatible with a different option setting, I think that is to be expected, No?

[tamas-grosz-epam]

Yeah, I'd flag this issue solved and add a line in documentation that if oneOf is needed, then use only the working option

[stale]

This issue was closed because of lack of recent activity. Reopen if you still need assistance.