From bfc7bae3bc21f60b4b486559df353b4eb44cef5b Mon Sep 17 00:00:00 2001
From: Pathik Gandhi <gr8pathik@gmail.com>
Date: Wed, 13 Mar 2019 23:47:12 +0530
Subject: [PATCH 1/3] #804 - Bug Fix - Empty divs are created

---
 src/components/fields/ArrayField.js       |  4 ++--
 src/components/fields/DescriptionField.js |  3 +--
 src/components/fields/SchemaField.js      | 12 ++++--------
 test/ArrayFieldTemplate_test.js           | 13 ++++++++++---
 test/SchemaField_test.js                  |  2 +-
 5 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/src/components/fields/ArrayField.js b/src/components/fields/ArrayField.js
index f60e5b86ff..c769ddd8fa 100644
--- a/src/components/fields/ArrayField.js
+++ b/src/components/fields/ArrayField.js
@@ -22,7 +22,7 @@ import {
 function ArrayFieldTitle({ TitleField, idSchema, title, required }) {
   if (!title) {
     // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
   const id = `${idSchema.$id}__title`;
   return <TitleField id={id} title={title} required={required} />;
@@ -31,7 +31,7 @@ function ArrayFieldTitle({ TitleField, idSchema, title, required }) {
 function ArrayFieldDescription({ DescriptionField, idSchema, description }) {
   if (!description) {
     // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
   const id = `${idSchema.$id}__description`;
   return <DescriptionField id={id} description={description} />;
diff --git a/src/components/fields/DescriptionField.js b/src/components/fields/DescriptionField.js
index b1ac9a2362..25ed1c79c7 100644
--- a/src/components/fields/DescriptionField.js
+++ b/src/components/fields/DescriptionField.js
@@ -4,8 +4,7 @@ import PropTypes from "prop-types";
 function DescriptionField(props) {
   const { id, description } = props;
   if (!description) {
-    // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
   if (typeof description === "string") {
     return (
diff --git a/src/components/fields/SchemaField.js b/src/components/fields/SchemaField.js
index bf60a3e412..a48523d866 100644
--- a/src/components/fields/SchemaField.js
+++ b/src/components/fields/SchemaField.js
@@ -61,8 +61,7 @@ function getFieldComponent(schema, uiSchema, idSchema, fields) {
 function Label(props) {
   const { label, required, id } = props;
   if (!label) {
-    // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
   return (
     <label className="control-label" htmlFor={id}>
@@ -88,8 +87,7 @@ function LabelInput(props) {
 function Help(props) {
   const { help } = props;
   if (!help) {
-    // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
   if (typeof help === "string") {
     return <p className="help-block">{help}</p>;
@@ -100,7 +98,7 @@ function Help(props) {
 function ErrorList(props) {
   const { errors = [] } = props;
   if (errors.length === 0) {
-    return <div />;
+    return null;
   }
 
   return (
@@ -254,10 +252,8 @@ function SchemaFieldRender(props) {
   const disabled = Boolean(props.disabled || uiSchema["ui:disabled"]);
   const readonly = Boolean(props.readonly || uiSchema["ui:readonly"]);
   const autofocus = Boolean(props.autofocus || uiSchema["ui:autofocus"]);
-
   if (Object.keys(schema).length === 0) {
-    // See #312: Ensure compatibility with old versions of React.
-    return <div />;
+    return null;
   }
 
   const uiOptions = getUiOptions(uiSchema);
diff --git a/test/ArrayFieldTemplate_test.js b/test/ArrayFieldTemplate_test.js
index b6bad381e8..c1a4c39991 100644
--- a/test/ArrayFieldTemplate_test.js
+++ b/test/ArrayFieldTemplate_test.js
@@ -42,7 +42,13 @@ describe("ArrayFieldTemplate", () => {
     describe("Stateful ArrayFieldTemplate", () => {
       class ArrayFieldTemplate extends PureComponent {
         render() {
-          return <div>{this.props.items.map(item => item.element)}</div>;
+          return (
+            <div className="field-content">
+              {this.props.items.map((item, i) => (
+                <div key={i}>item.children</div>
+              ))}
+            </div>
+          );
         }
       }
 
@@ -52,8 +58,9 @@ describe("ArrayFieldTemplate", () => {
           formData,
           ArrayFieldTemplate,
         });
-
-        expect(node.querySelectorAll(".field-array div")).to.have.length.of(3);
+        expect(
+          node.querySelectorAll(".field-array .field-content div")
+        ).to.have.length.of(3);
       });
     });
 
diff --git a/test/SchemaField_test.js b/test/SchemaField_test.js
index fa503d767e..80115c897c 100644
--- a/test/SchemaField_test.js
+++ b/test/SchemaField_test.js
@@ -108,7 +108,7 @@ describe("SchemaField", () => {
               receivedProps = props;
             }
             render() {
-              return <div />;
+              return null;
             }
           },
         },

From f0673b557041413a1cdb0ac8845a692eb577e9bd Mon Sep 17 00:00:00 2001
From: Pathik Gandhi <gr8pathik@gmail.com>
Date: Thu, 14 Mar 2019 10:59:26 +0530
Subject: [PATCH 2/3] #804 - Bug Fix - Empty divs are created - Refactoring

---
 src/components/fields/ArrayField.js | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/components/fields/ArrayField.js b/src/components/fields/ArrayField.js
index c769ddd8fa..58d321f712 100644
--- a/src/components/fields/ArrayField.js
+++ b/src/components/fields/ArrayField.js
@@ -21,7 +21,6 @@ import {
 
 function ArrayFieldTitle({ TitleField, idSchema, title, required }) {
   if (!title) {
-    // See #312: Ensure compatibility with old versions of React.
     return null;
   }
   const id = `${idSchema.$id}__title`;
@@ -30,7 +29,6 @@ function ArrayFieldTitle({ TitleField, idSchema, title, required }) {
 
 function ArrayFieldDescription({ DescriptionField, idSchema, description }) {
   if (!description) {
-    // See #312: Ensure compatibility with old versions of React.
     return null;
   }
   const id = `${idSchema.$id}__description`;

From c6684a62361e772f99c80ca04d4ee176df4897a2 Mon Sep 17 00:00:00 2001
From: Pathik Gandhi <gr8pathik@gmail.com>
Date: Thu, 28 Mar 2019 12:14:56 +0530
Subject: [PATCH 3/3] #226 - Restrict accepted mimetypes in file widget

---
 playground/samples/files.js          | 11 ++++++++++-
 src/components/widgets/FileWidget.js |  3 ++-
 2 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/playground/samples/files.js b/playground/samples/files.js
index 7775ef2cd7..93d81a6e76 100644
--- a/playground/samples/files.js
+++ b/playground/samples/files.js
@@ -16,8 +16,17 @@ module.exports = {
           format: "data-url",
         },
       },
+      filesAccept: {
+        type: "string",
+        format: "data-url",
+        title: "Single File with Accept attribute",
+      },
+    },
+  },
+  uiSchema: {
+    filesAccept: {
+      "ui:accept": ".pdf",
     },
   },
-  uiSchema: {},
   formData: {},
 };
diff --git a/src/components/widgets/FileWidget.js b/src/components/widgets/FileWidget.js
index 856dad00a3..5bd4909900 100644
--- a/src/components/widgets/FileWidget.js
+++ b/src/components/widgets/FileWidget.js
@@ -90,7 +90,7 @@ class FileWidget extends Component {
   };
 
   render() {
-    const { multiple, id, readonly, disabled, autofocus } = this.props;
+    const { multiple, id, readonly, disabled, autofocus, options } = this.props;
     const { filesInfo } = this.state;
     return (
       <div>
@@ -104,6 +104,7 @@ class FileWidget extends Component {
             defaultValue=""
             autoFocus={autofocus}
             multiple={multiple}
+            accept={options.accept}
           />
         </p>
         <FilesInfo filesInfo={filesInfo} />