This repository has been archived by the owner on Jun 9, 2020. It is now read-only.
Enable tracing for all threads. #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 20, 2014 10:52
…or thread-local enable_count.
|
Tested and works for me. |
|
Works for me too. This is also very short patch so hopefully not too hard to review. In today's world where many programs need multiple threads, supporting profiling multiple threads is very useful. |
ahippo
added a commit
to ahippo/line_profiler
that referenced
this pull request
Mar 13, 2018
Enable tracing for all threads.
|
After four years, I am also surprised that this has not been merged. It has been used for a number of my multithreaded projects, and it painful to carry around a non-pip version. Pinging @rkern ... |
caethan
added
the
being considered
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PyEval_SetTrace only sets the current thread's tracing callback. This patch makes enable_count thread-local, so that tracing is enabled/disabled on a thread-specific basis. Without this, only the thread that happened to trigger the enable() call would have had tracing enabled.