Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid shell calls for interacting with git #15

Open
dideler opened this issue Mar 31, 2018 · 0 comments
Open

Avoid shell calls for interacting with git #15

dideler opened this issue Mar 31, 2018 · 0 comments

Comments

@dideler
Copy link
Contributor

dideler commented Mar 31, 2018

Right now we're wrapping the git binary in child process calls that are executed in their own shell instance. That's not very efficient.

Consider using libgit bindings or an ini file parser (could be one specific to git config, e.g. https://github.com/jonschlinkert/parse-git-config or https://github.com/eugeneware/git-config).

Note that the parsers will be read-only, so if we use those, there may have to be a compromise where we only use it for reads and continue to use a shell for writes. We could write to the file without going through git, but then we don't get any of the protection that git provides (e.g. helps prevent you from setting illegal config).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant