Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI Improvement for suggested co-authors #88

Open
rkotze opened this issue Oct 25, 2022 · 0 comments
Open

CI Improvement for suggested co-authors #88

rkotze opened this issue Oct 25, 2022 · 0 comments
Labels
Code improvements Improvements to code design and organisation help wanted Extra attention is needed

Comments

@rkotze
Copy link
Owner

rkotze commented Oct 25, 2022

Context

Suggest-coauthors command lists the local contributors to the git repo. When testing in the CI it's important to check out the whole repository over just a single commit because a single commit will only contain one contributor. The tests check for an old contributor and so this will cause a failure. See here this publish failure.

Current mitigation

I've moved the minified test into the main CI to catch the issues earlier. However to have more control over the test data/environment a different solution might be helpful.

Suggested solution

Extend the temporarily created repo for testing to include commits with different authors. Then test one of them shows when running the suggest coauthors command.

@rkotze rkotze added Code improvements Improvements to code design and organisation help wanted Extra attention is needed labels Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code improvements Improvements to code design and organisation help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant