Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to remove .remoteCid flag #112

Open
MichaelHirn opened this issue Sep 13, 2019 · 0 comments
Open

Try to remove .remoteCid flag #112

MichaelHirn opened this issue Sep 13, 2019 · 0 comments
Assignees
Labels
refactor rlay-client-lib issues pertaining to @rlay/rlay-client-lib
Milestone

Comments

@MichaelHirn
Copy link
Contributor

MichaelHirn commented Sep 13, 2019

The .remoteCid flag, introduced pre-v0.2.0, is a way to signal if the entity exists remotely or not. However, when casting between entities, especially higher-level entities as exposed by rlay-ontology packages, the default absence of the .remoteCid flag causes ugly code. E.g.

newEntity.remoteCid = oldEntity.remoteCid

As @hobofan suggested, the presence of such a flag may just be cosmetically and not necessary for any of the methods (e.g. assert) to work properly. As a first instance we will therefore try to remove the .remoteCid flag to see if any behavior changes occur.

As a second step, the entity could hold state about which assertions it pass through to the client to optimize some of its behaviors

@MichaelHirn MichaelHirn added rlay-client-lib issues pertaining to @rlay/rlay-client-lib refactor labels Sep 13, 2019
@MichaelHirn MichaelHirn added this to the v0.3.0 milestone Sep 13, 2019
@MichaelHirn MichaelHirn self-assigned this Sep 13, 2019
@MichaelHirn MichaelHirn changed the title Try to remote .remoteCid flag Try to remove .remoteCid flag Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor rlay-client-lib issues pertaining to @rlay/rlay-client-lib
Projects
None yet
Development

No branches or pull requests

1 participant