Update resolvconf on changes

[Poil]

Hi,

Update resolvconf on changes is not on changes, it's reloading at each puppet runs

Best regards,

[tdm4]

Would this work?

diff --git a/modules/dnsmasq/manifests/init.pp b/modules/dnsmasq/manifests/init.pp
index 084a6a7..3ddce9a 100644
--- a/modules/dnsmasq/manifests/init.pp
+++ b/modules/dnsmasq/manifests/init.pp
@@ -57,6 +57,7 @@ class dnsmasq (
     path    => [ '/usr/bin', '/usr/sbin', '/bin', '/sbin', ],
     require => Package[$dnsmasq_package],
     before  => File[$dnsmasq_conffile],
+    notify  => Exec['reload_resolvconf'],
   }

   service { 'dnsmasq':
@@ -68,11 +69,12 @@ class dnsmasq (
   }

   exec { 'reload_resolvconf':
-    provider => shell,
-    command  => '/sbin/resolvconf -u',
-    user     => root,
-    onlyif   => 'test -f /sbin/resolvconf',
-    before   => Service['dnsmasq'],
+    provider    => shell,
+    command     => '/sbin/resolvconf -u',
+    user        => root,
+    onlyif      => 'test -f /sbin/resolvconf',
+    before      => Service['dnsmasq'],
+    refreshonly => true,
   }

   if $dnsmasq_confdir {

[tdm4]

Thing is, I'm not 100% sure when reload_resolvconf would need to be run except if the dnsmasq config file changes?

[dje4om]

Hi,

According to this file : /etc/resolvconf/update.d/dnsmasq
It seems, it should occur only if dnsmasq.conf is updated.

Notify on concat resource for dnsmasq.conf and refreshonly => true works as expected.