You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
rlidwka/render-readme#4 allows DoSing a sinopia server by simply attempting to expand a single readme. There should be some sort of timeout when doing synchronous processing of a request (if possible in node 😟, really not sure if it is). Maybe potentially processing intensive operations such as rendering the readmes should be moved to a subprocess to allow doing them asynchronously?
The text was updated successfully, but these errors were encountered:
Fixed in sinopia@1.1.0. It was caused by highlightAuto, and I turned off the entire thing.
Thanks for reporting!
I think all those processing-intensive operations are bugs which need to be fixed. So I doubt moving it to subprocesses is really necessary. You can launch multiple sinopia copies with something like pm2 though.
rlidwka/render-readme#4 allows DoSing a sinopia server by simply attempting to expand a single readme. There should be some sort of timeout when doing synchronous processing of a request (if possible in node 😟, really not sure if it is). Maybe potentially processing intensive operations such as rendering the readmes should be moved to a subprocess to allow doing them asynchronously?
The text was updated successfully, but these errors were encountered: