Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long duration requests leave server hung #206

Closed
Nemo157 opened this issue Feb 22, 2015 · 1 comment
Closed

Long duration requests leave server hung #206

Nemo157 opened this issue Feb 22, 2015 · 1 comment

Comments

@Nemo157
Copy link

Nemo157 commented Feb 22, 2015

rlidwka/render-readme#4 allows DoSing a sinopia server by simply attempting to expand a single readme. There should be some sort of timeout when doing synchronous processing of a request (if possible in node 😟, really not sure if it is). Maybe potentially processing intensive operations such as rendering the readmes should be moved to a subprocess to allow doing them asynchronously?

@rlidwka
Copy link
Owner

rlidwka commented Mar 30, 2015

Fixed in sinopia@1.1.0. It was caused by highlightAuto, and I turned off the entire thing.

Thanks for reporting!

I think all those processing-intensive operations are bugs which need to be fixed. So I doubt moving it to subprocesses is really necessary. You can launch multiple sinopia copies with something like pm2 though.

@rlidwka rlidwka closed this as completed Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants