Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [WINDOWS] Special characters are not saved properly #148

Closed
kishikaisei opened this issue Jul 12, 2022 · 3 comments
Closed

[BUG] [WINDOWS] Special characters are not saved properly #148

kishikaisei opened this issue Jul 12, 2022 · 3 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@kishikaisei
Copy link

Describe the bug
The path for the sessions is not shown properly, functionally they work, but visually they are wrong:
C:/path/to/project is shown as C++%path%to%project (: -> ++, and / -> %)

To Reproduce
Steps to reproduce the behavior:

  1. Save any session on windows
  2. Open "autosession search"

Expected behavior
A clear and concise description of what you expected to happen.
To see the path correctly with the proper characters

Screenshots
If applicable, add screenshots to help explain your problem.
image

Baseline (please complete the following information):

@kishikaisei kishikaisei added the bug Something isn't working label Jul 12, 2022
@rmagatti
Copy link
Owner

Hey @kishikaisei thanks for the issue submission! 🎉 I'd be happy to accept a PR if you or anyone's got some free time to dive into this. I don't really have the means to look deeper into Windows issues with this plugin unfortunately.

@rmagatti rmagatti added the help wanted Extra attention is needed label Sep 22, 2022
@nnako
Copy link

nnako commented Feb 18, 2023

within Windows operating systems there are different restrictions concerning usable characters for valid file and folder names. to name a few obvious ones:

  • no case-sensitivity for file names on windows systems
  • no colons : within a file name. only to separate the drive identifier from the rest of the path
  • no backslash \ within the file names as they are used to separate folders
  • ...

thus, the replacement of : with ++ and \ with % at least renders the file names valid for session files. This is not very pretty (I would prefer a simple underscore _ for any of the invalid characters) but at least, windows doesn't get confused.

@kishikaisei : what would you like to see as a "solution", here?

If it was only about representing that session file name within the nvim editor when listing all available sessions, that should not be such a big problem for implementation,

@cameronr
Copy link
Collaborator

cameronr commented Aug 2, 2024

@rmagatti I think this can be closed now

@rmagatti rmagatti closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants