Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collector endpoint path supporting Zipkin v1 or v2? #28

Open
nobeh opened this issue Sep 20, 2018 · 0 comments
Open

Collector endpoint path supporting Zipkin v1 or v2? #28

nobeh opened this issue Sep 20, 2018 · 0 comments

Comments

@nobeh
Copy link

nobeh commented Sep 20, 2018 •
edited
Loading

In this comment, it is stated that zipkin-cpp-opentracing supports Zipkin v2 format:

the zipkin c++ library currently only supports the V2 style spans

But when looking at zipkin_core_constants.h, the collector API sounds different:

const std::string DEFAULT_COLLECTOR_ENDPOINT = "/api/v1/spans"

Testing with nginx and this module, it seems to be working even with a v2 collector endpoint.

Is this a configuration bug? Could you please confirm which version is supported?
And maybe, make the endpoint API path also a configuration?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nobeh